Skip to content

Upgrade zip-related dependencies #497

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
matzefriedrich wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Upgrade zip-related dependencies #497

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8cd743a
Update zip and zip-extensions dependencies, adjust imports, and refin…
matzefriedrich Dec 16, 2025
a09585a
Update Cargo.lock to include new and upgraded dependencies
matzefriedrich Dec 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
187 changes: 141 additions & 46 deletions Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions libium/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,10 +30,10 @@ clap.workspace = true
derive_more = { version = "2.0", features = ["display"] }
serde = { version = "1.0", features = ["derive"] }
url = { version = "2.5", features = ["serde"] }
zip-extensions = "0.8"
zip-extensions = "0.13"
futures-util = "0.3"
directories = "6.0"
thiserror = "2.0"
regex = "1.11"
sha1 = "0.10"
zip = "2.5"
zip = "6.0"
4 changes: 3 additions & 1 deletion libium/src/modpack/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,9 @@ pub mod add;
pub mod curseforge;
pub mod modrinth;

pub use zip_extensions::{zip_create_from_directory, zip_extract};
pub use zip_extensions::{
deflate::zip_writer::zip_create_from_directory, inflate::zip_extract::zip_extract,
};

use crate::read_wrapper;
use std::io::{Read, Seek};
Expand Down
4 changes: 3 additions & 1 deletion libium/src/modpack/modrinth/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ use std::{
};

use zip::{write::SimpleFileOptions, ZipWriter};
use zip_extensions::ZipWriterExtensions;
use zip_extensions::deflate::zip_writer_extensions::ZipWriterExtensions;

/// Create a Modrinth modpack at `output` using the provided `metadata` and optional `overrides`
pub fn create(
Expand Down Expand Up @@ -46,5 +46,7 @@ pub fn create(
writer.create_from_directory(&overrides.to_owned())?;
}

writer.finish()?;

Ok(())
}