This repository was archived by the owner on Sep 8, 2023. It is now read-only.
Adjust typoDescender formula so result is a negative number?#116
Open
eliheuer wants to merge 2 commits intogooglefonts:mainfrom
Open
Adjust typoDescender formula so result is a negative number?#116eliheuer wants to merge 2 commits intogooglefonts:mainfrom
eliheuer wants to merge 2 commits intogooglefonts:mainfrom
Conversation
Contributor
|
I am thinking maybe we could make it even more explanatory like:
|
m4rc1e
reviewed
Oct 14, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
typoDescender(UPM * 1.2 - CapsHeight) / 2)formula doesn't produce a negative number, so I thought this might be less confusing:(UPM * 1.2 - CapsHeight) / -2)This is subjective and there might be some reason to leave it as is I don't know about, so please close or ignore this PR if that is the case, this just makes more sense to me. Thanks!