This repository was archived by the owner on Mar 5, 2026. It is now read-only.
feat: Row readers using storage API acceleration can leverage full precision arrow values#656
Merged
gcf-merge-on-green[bot] merged 18 commits intomainfrom Mar 3, 2026
Merged
Conversation
This reverts commit d56c01f.
product-auto-label
bot
added
size: m
alvarowolfx
approved these changes
Mar 3, 2026
Contributor
alvarowolfx
left a comment
alvarowolfx
left a comment
There was a problem hiding this comment.
just a nit on the inline comment. I don't think is needed
| if (request.arrowSerializationOptions) { | ||
| // Use Object.assign instead of defining property inline. | ||
| // We prefer no arrowSerializationOptions property in the JSON request | ||
| // instead of having an `arrowSerializationOptions: undefined` mapping. |
Contributor
There was a problem hiding this comment.
nit: I think this comment is a bit redundant
danieljbruce
added
automerge
gcf-owl-bot
bot
removed
the
owlbot:run
gcf-merge-on-green
bot
removed
the
automerge
This was referenced Mar 3, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR allows users to fetch high precision timestamps for read calls with arrow readers. Previous to this PR there was no way users could
Impact
With the ArrowReaders in this code repository, now users can fetch and consume data from the server that preserves high precision timestamps on the backend.
Testing
A system test is added that proves the timestamp fetched from the server is high precision.
Additional Information
Something to be aware of is that this PR introduces an API change. For various read methods that users can call they can specify a value for the
arrowSerializationOptionsproperty of their request which will be passed onto the server. This allows users to opt into receiving high precision timestamps instead of getting them automatically because automatically opting them in could change values they are currently getting from ints to strings which is a breaking change.Support for Avro readers will be done in a separate PR.
In this PR we make the minimal amount of changes necessary to allow users to fetch high precision timestamps for arrow readers, but there may be additional changes that could make it easier for users to write code to fetch high precision timestamps instead of the current system test we have. That should be deliberated in a separate PR though. For instance, we can expand the
GetRowsOptionsinterface.