Skip to content

chore(version-scanner): split file path in output and format reporting columns#17476

Merged
chalmerlowe merged 2 commits into
mainfrom
feat/version-scanner-format
Jun 16, 2026
Merged

chore(version-scanner): split file path in output and format reporting columns#17476
chalmerlowe merged 2 commits into
mainfrom
feat/version-scanner-format

Conversation

@chalmerlowe

@chalmerlowe chalmerlowe commented Jun 16, 2026

Copy link
Copy Markdown
Contributor

This pull request polishes the output format of the version_scanner. It splits the scanned file's path into directory and filename columns, and places the dependency and target version columns upfront to help reviewers quickly scan the findings.

Key changes:

  • Adds file_name, dependency, and version columns to the report formats.
  • Re-orders output columns in CSV and Google Sheets uploads.
  • Updates unit tests to verify the new column ordering.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request enhances the version scanner by adding "file_name", "dependency", and "version" fields to the CSV and spreadsheet reports, updating the corresponding unit tests, and cleaning up unused imports. The feedback recommends updating the type hints of "format_for_raw_csv" to use "Dict[str, Any]" instead of "Dict[str, str]" to avoid static analysis errors caused by non-string values like integers.

Comment thread scripts/version_scanner/version_scanner.py
@chalmerlowe chalmerlowe marked this pull request as ready for review June 16, 2026 15:09
@chalmerlowe chalmerlowe requested a review from a team as a code owner June 16, 2026 15:09
@chalmerlowe chalmerlowe merged commit d3dd066 into main Jun 16, 2026
31 checks passed
@chalmerlowe chalmerlowe deleted the feat/version-scanner-format branch June 16, 2026 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants