chore(google-auth): drop python 3.7 EOL false positives and refactor metrics telemetry#17463
Open
chalmerlowe wants to merge 5 commits into
Open
chore(google-auth): drop python 3.7 EOL false positives and refactor metrics telemetry#17463chalmerlowe wants to merge 5 commits into
chalmerlowe wants to merge 5 commits into
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request cleans up Python 3.7 references across documentation, metrics comments, and tests, updating them to use dynamic versioning or placeholders. It also updates aiohttp session checks to use the public auto_decompress attribute instead of the private _auto_decompress. Feedback on these changes suggests using getattr for safer attribute access on potentially mocked aiohttp sessions, and correcting minor typos and duplications in the updated metrics comments.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request eliminates EOL Python 3.7 false positives from the
google-authcodebase to ensure a clean signal from version scanner compliance checks.Why these changes are made:
gl-python/3.7) have been replaced with abstract version placeholders (<python-version>) in comments with formatting examples and in test assertions. This prevents scanner alerts while retaining the ability to verify HTTP client request formatting behavior._auto_decompressinternal attribute access in theaiohttptransport with the standard publicauto_decompressproperty (supported inaiohttp >= 3.8), allowing the removal of old TODOs from the source code that referenced 3.7.python_requires) to enforce runtime compatibility.Supports resolution of the internal bug: #512225398