feat(bigquery-jdbc): implement JDBC getObject type coercion support#13257
Open
Neenu1995 wants to merge 3 commits into
Open
feat(bigquery-jdbc): implement JDBC getObject type coercion support#13257Neenu1995 wants to merge 3 commits into
Neenu1995 wants to merge 3 commits into
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request implements the getObject(..., Class type) method in BigQueryBaseResultSet and introduces several new type coercions in BigQueryTypeCoercionUtility, primarily for Java 8 date/time types and BigDecimal. The review identifies a missing import for Instant and potential timezone inconsistencies when converting Timestamp to LocalDateTime. Additionally, the feedback suggests simplifying LocalTime conversion, wrapping runtime exceptions in SQLException for JDBC compliance, and fixing a precision issue in the test assertions.
Neenu1995
changed the title
logachev
approved these changes
May 22, 2026
|
|
||
| public static Stream<Arguments> successfulCoercionCases() { | ||
| return Stream.of( | ||
| Arguments.of("fourteenth", LocalDate.class, LocalDate.of(2020, 1, 15)), |
Contributor
There was a problem hiding this comment.
Can we also add regular Date/Timestamp etc?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
b/515411678
Finalizes JDBC 4.2 support by fully implementing standard
ResultSet.getObject(int, Class<T>)andResultSet.getObject(String, Class<T>)retrieval.Key Changes
getObjectlogic inBigQueryBaseResultSetto leverageBigQueryTypeCoercionUtility.BigQueryNoOpsResultSet.Integer,Long,Double,Float) andStringtoBigDecimalinBigQueryTypeCoercionUtility.BigQueryJsonResultSetTestandBigQueryArrowResultSetTestverifying standard types (java.timetypes, Booleans, Numbers, andBigDecimal) and confirming that invalid coercions raiseSQLExceptionas expected.