feat: mTLS configuration via x.509 for asynchronous session in google-auth#1959
feat: mTLS configuration via x.509 for asynchronous session in google-auth#1959agrawalradhika-cell wants to merge 12 commits intomainfrom
Conversation
Signed-off-by: Radhika Agrawal <agrawalradhika@google.com>
Signed-off-by: Radhika Agrawal <agrawalradhika@google.com>
Signed-off-by: Radhika Agrawal <agrawalradhika@google.com>
Signed-off-by: Radhika Agrawal <agrawalradhika@google.com>
… handling async and removing encrypted_key complication Signed-off-by: Radhika Agrawal <agrawalradhika@google.com>
Signed-off-by: Radhika Agrawal <agrawalradhika@google.com>
… sync helpers can be reused Signed-off-by: Radhika Agrawal <agrawalradhika@google.com>
…-auth Signed-off-by: Radhika Agrawal <agrawalradhika@google.com>
Summary of ChangesHello @agrawalradhika-cell, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly enhances the Highlights
Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request introduces mTLS configuration capabilities for asynchronous sessions in google-auth, leveraging x.509 certificates. Key changes include the addition of a new mtls.py module for handling certificate and key management, updates to AsyncAuthorizedSession to support mTLS channel configuration, and modifications to internal helper functions to accommodate context-aware certificate sources. Comprehensive unit tests have also been added to ensure the correctness and robustness of the new mTLS functionality.
Signed-off-by: Radhika Agrawal <agrawalradhika@google.com>
Signed-off-by: Radhika Agrawal <agrawalradhika@google.com>
…of race conditions Signed-off-by: Radhika Agrawal <agrawalradhika@google.com>
|
The system-3.10 is failing with unrelated |
This pull request introduces support for Mutual TLS (mTLS) in the asynchronous transport layer of the google-auth library. It enables AsyncAuthorizedSession to automatically discover and utilize client certificates for secure communication with Google Cloud APIs. See go/caa:x509-async-support for details.
Please note: Only x.509 creds are in scope of this project currently. Context aware or ECP credentials are not in scope of this project currently.
This PR is second part of #1956