[codegen 1.5] Improve channel lowering's metadata & error handling #3633
+39
−14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
copybara-service
bot
force-pushed
the
test_849268376
branch
from
86d7818 to
1f753f4
Compare
We preserve more metadata about channel connectors, and also explicitly block emission of one-shot Send logic (inherently sequential) for combinational Proc codegen. This fixes several more tests. PiperOrigin-RevId: 851833779
copybara-service
bot
force-pushed
the
test_849268376
branch
from
1f753f4 to
86836a9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[codegen 1.5] Improve channel lowering's metadata & error handling
We preserve more metadata about channel connectors, and also explicitly block emission of one-shot Send logic (inherently sequential) for combinational Proc codegen.
This fixes several more tests.