[codegen 1.5] Enable the simplest proc test for new block conversion #3628
+167
−75
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
copybara-service
bot
force-pushed
the
test_849163225
branch
3 times, most recently
from
a6211b7 to
17f9820
Compare
This required small patches to channel & state lowering, as well as to how we transfer Nodes into ScheduledBlocks: 1. Channel lowering now handles single-value channnels without crashing in some circumstances. (Whoops.) 2. State lowering now cleans up after itself. 3. ScheduledBlock conversion now takes ownership of the node name as well as the node. We also add dataflow simplification to the pipeline (matching codegen 1.0). PiperOrigin-RevId: 851382186
copybara-service
bot
force-pushed
the
test_849163225
branch
from
17f9820 to
bcd6295
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[codegen 1.5] Enable the simplest proc test for new block conversion
This required small patches to channel & state lowering, as well as to how we transfer Nodes into ScheduledBlocks:
We also add dataflow simplification to the pipeline (matching codegen 1.0).