[codegen 1.5] Enable almost all Function-oriented block conversion tests #3610
+604
−42
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
copybara-service
bot
force-pushed
the
test_848321070
branch
4 times, most recently
from
f8fcddd to
a606606
Compare
Required adding additional passes to the block conversion pipeline in order to clean up unnecessary flow-control logic & registers: 1. a new `RegisterCleanupPass` to remove unused registers and simplify register writes, and 2. a final `DeadCodeEliminationPass` to remove all remaining dead nodes. We also needed a small patch to `FunctionIOLoweringPass` - and a slightly-larger patch to `FlowControlInsertionPass` to avoid maintaining unnecessary flow control logic for a function meant to ignore I/O validity. PiperOrigin-RevId: 851326806
copybara-service
bot
force-pushed
the
test_848321070
branch
from
a606606 to
45c9bdc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[codegen 1.5] Enable almost all Function-oriented block conversion tests
Required adding additional passes to the block conversion pipeline in order to clean up unnecessary flow-control logic & registers:
RegisterCleanupPassto remove unused registers and simplify register writes, andDeadCodeEliminationPassto remove all remaining dead nodes.We also needed a small patch to
FunctionIOLoweringPass- and a slightly-larger patch toFlowControlInsertionPassto avoid maintaining unnecessary flow control logic for a function meant to ignore I/O validity.