OboeTester: Add MultiChannelFileRecording.h #2220
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flamme
reviewed
May 28, 2025
flamme
reviewed
May 28, 2025
Collaborator
flamme
left a comment
flamme
left a comment
There was a problem hiding this comment.
I'm worried that this PR may cause some unexpected latency and glitch issues that it introduces extra latency by changing memory copy to file I/O.
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MultiChannelRecording.h currently writes to a buffer. This means our record and play tests only record the last 10 seconds of audio. We should record much more. This PR introduces MultiChannelFileRecording.h which writes to a file instead.