Skip to content

Add test confirming that login works without contact obj URI #2983

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
CydeWeys merged 1 commit into from
Mar 19, 2026
+11 −1
Merged

Add test confirming that login works without contact obj URI #2983

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion core/src/test/java/google/registry/flows/session/LoginFlowTestCase.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,7 +133,7 @@ void testFailure_invalidContactObjectUri() {
}

@Test
void testSuccess_contactObjectUri_worksWhenNotProhibited() throws Exception {
void testSuccess_contactObjectUriSent_worksWhenNotProhibited() throws Exception {
persistResource(
FeatureFlag.get(PROHIBIT_CONTACT_OBJECTS_ON_LOGIN)
.asBuilder()
Expand All @@ -142,6 +142,16 @@ void testSuccess_contactObjectUri_worksWhenNotProhibited() throws Exception {
doSuccessfulTest("login_with_contact_objuri.xml");
}

@Test
void testSuccess_contactObjectUriNotSent_worksWhenNotProhibited() throws Exception {
persistResource(
FeatureFlag.get(PROHIBIT_CONTACT_OBJECTS_ON_LOGIN)
.asBuilder()
.setStatusMap(ImmutableSortedMap.of(START_OF_TIME, FeatureStatus.INACTIVE))
.build());
doSuccessfulTest("login_valid.xml");
}

@Test
void testFailure_invalidTypes() {
doFailingTest("login_invalid_types.xml", UnimplementedObjectServiceException.class);
Expand Down
Loading