Skip to content

feat(wish/cpp): make sure to stop the event loop in the destructor #47

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tyoshino merged 1 commit into from
Apr 27, 2026
Merged

feat(wish/cpp): make sure to stop the event loop in the destructor #47

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions wish/cpp/src/plain_client.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,9 @@ PlainClient::PlainClient(const std::string& host, int port)
handler_(nullptr) {}

PlainClient::~PlainClient() {
if (base_) {
event_base_loopbreak(base_);
}
if (dns_base_) {
evdns_base_free(dns_base_, 0);
}
Expand Down
9 changes: 6 additions & 3 deletions wish/cpp/src/tls_client.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,15 +20,18 @@ TlsClient::TlsClient(const std::string& ca_file, const std::string& cert_file,
handler_(nullptr) {}

TlsClient::~TlsClient() {
// Signal the event loop to exit before freeing it. If Run() is still
// executing in another thread (e.g. the caller forgot to call Stop()),
// event_base_loopbreak wakes it up immediately so event_base_free is safe.
if (base_) {
event_base_loopbreak(base_);
}
if (dns_base_) {
evdns_base_free(dns_base_, 0);
}
if (base_) {
event_base_free(base_);
}
// WishHandler deletes itself when the connection closes
// But if it wasn't started, we might need to delete it.
// Assuming it manages its own lifecycle for now.
}

bool TlsClient::Init() {
Expand Down