Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion langfun/core/data/conversion/gemini.py
Original file line number Diff line number Diff line change
Expand Up @@ -83,12 +83,14 @@ def _convert_chunk(
if video_metadata:
result['videoMetadata'] = video_metadata
return result
if chunk.uri and chunk.uri.startswith('gs://'):
always_send_content = False
if chunk.is_text:
return {'text': chunk.to_text()}
if (
not always_send_content
and chunk.uri
and chunk.uri.lower().startswith(('http:', 'https:', 'ftp:'))
and chunk.uri.lower().startswith(('http:', 'https:', 'ftp:', 'gs:'))
):
return {
'fileData': {
Expand Down
24 changes: 24 additions & 0 deletions langfun/core/data/conversion/gemini_test.py
Original file line number Diff line number Diff line change
Expand Up @@ -92,6 +92,30 @@ def test_as_format_with_image(self):
},
)

def test_as_format_with_gcs_uri(self):
self.assertEqual(
lf.Template(
'Summarize {{doc}}',
doc=lf_modalities.Custom.from_uri(
'gs://my-bucket/temp/doc.pdf', mime='application/pdf'
),
)
.render()
.as_gemini_format(),
{
'role': 'user',
'parts': [
{'text': 'Summarize'},
{
'fileData': {
'fileUri': 'gs://my-bucket/temp/doc.pdf',
'mimeType': 'application/pdf',
}
},
],
},
)

def test_as_format_youtube_with_video_metadata(self):
self.assertEqual(
lf.Template(
Expand Down
Loading