-
Notifications
You must be signed in to change notification settings - Fork 2.8k
Noto Sans Bengali: Version 3.010 added #10090
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Taken from the upstream repo https://github.com/notofonts/bengali at commit notofonts/bengali@07b2d57.
FontSpector reportfontspector version: 1.5.2 Check results[1] ofl/notosansbengali/DESCRIPTION.en_us.html🔥 FAIL Does DESCRIPTION file contain a upstream Git repo URL? (googlefonts/description/git_url)
[2] ofl/notosansbengali/article/ARTICLE.en_us.html🔥 FAIL Does DESCRIPTION file contain broken links? (googlefonts/description/broken_links)
🔥 FAIL Does DESCRIPTION file contain a upstream Git repo URL? (googlefonts/description/git_url)
[5] ofl/notosansbengali🔥 FAIL Check samples can be rendered (googlefonts/metadata/can_render_samples)
|
| Message | Languages |
|---|---|
| Auxiliary orthography codepoints: | * fi_Latn (Finnish) |
| The following auxiliary characters are missing from the font: Ǧ | |
| The following auxiliary characters are missing from the font: Ǥ | |
| The following auxiliary characters are missing from the font: Ȟ | |
| The following auxiliary characters are missing from the font: Ǩ | |
| The following auxiliary characters are missing from the font: Ŋ | |
| The following auxiliary characters are missing from the font: Ŝ | |
| The following auxiliary characters are missing from the font: Ţ | |
| The following auxiliary characters are missing from the font: Ŧ | |
| The following auxiliary characters are missing from the font: Ʒ | |
| The following auxiliary characters are missing from the font: Ǯ | |
| The following auxiliary characters are missing from the font: ǧ | |
| The following auxiliary characters are missing from the font: ǥ | |
| The following auxiliary characters are missing from the font: ȟ | |
| The following auxiliary characters are missing from the font: ǩ | |
| The following auxiliary characters are missing from the font: ŋ | |
| The following auxiliary characters are missing from the font: ŝ | |
| The following auxiliary characters are missing from the font: ţ | |
| The following auxiliary characters are missing from the font: ŧ | |
| The following auxiliary characters are missing from the font: ʒ | |
| The following auxiliary characters are missing from the font: ǯ | |
| Auxiliary orthography codepoints: | * cs_Latn (Czech) |
| The following auxiliary characters are missing from the font: Ĕ | * cy_Latn (Welsh) |
| The following auxiliary characters are missing from the font: Ĭ | * es_Latn (Spanish) |
| The following auxiliary characters are missing from the font: Ŏ | * hu_Latn (Hungarian) |
| The following auxiliary characters are missing from the font: Ō | * pt_Latn (Portuguese) |
| The following auxiliary characters are missing from the font: Ŭ | * sk_Latn (Slovak) |
| The following auxiliary characters are missing from the font: ĕ | * tr_Latn (Turkish) |
| The following auxiliary characters are missing from the font: ĭ | |
| The following auxiliary characters are missing from the font: ŏ | |
| The following auxiliary characters are missing from the font: ō | |
| The following auxiliary characters are missing from the font: ŭ | |
| Auxiliary orthography codepoints: | * da_Latn (Danish) |
| The following auxiliary characters are missing from the font: Ǿ | |
| The following auxiliary characters are missing from the font: ǿ | |
| Auxiliary orthography codepoints: | * fr_Latn (French) |
| The following auxiliary characters are missing from the font: Ǔ | |
| The following auxiliary characters are missing from the font: ſ | |
| The following auxiliary characters are missing from the font: ǔ | |
| Auxiliary orthography codepoints: | * nb_Latn (Norwegian Bokmål) |
| The following auxiliary characters are missing from the font: Ǎ | |
| The following auxiliary characters are missing from the font: Ŋ | |
| The following auxiliary characters are missing from the font: Ŧ | |
| The following auxiliary characters are missing from the font: ǎ | |
| The following auxiliary characters are missing from the font: ŋ | |
| The following auxiliary characters are missing from the font: ŧ | |
| Auxiliary orthography codepoints: | * de_Latn (German) |
| The following auxiliary characters are missing from the font: Ĕ | |
| The following auxiliary characters are missing from the font: Ĭ | |
| The following auxiliary characters are missing from the font: Ŏ | |
| The following auxiliary characters are missing from the font: Ō | |
| The following auxiliary characters are missing from the font: Ŭ | |
| The following auxiliary characters are missing from the font: ĕ | |
| The following auxiliary characters are missing from the font: ĭ | |
| The following auxiliary characters are missing from the font: ŏ | |
| The following auxiliary characters are missing from the font: ō | |
| The following auxiliary characters are missing from the font: ſ | |
| The following auxiliary characters are missing from the font: ŭ | |
| Auxiliary orthography codepoints: | * lv_Latn (Latvian) |
| The following auxiliary characters are missing from the font: Ō | |
| The following auxiliary characters are missing from the font: Ŗ | |
| The following auxiliary characters are missing from the font: ō | |
| The following auxiliary characters are missing from the font: ŗ | |
| Auxiliary orthography codepoints: | * ro_Latn (Romanian) |
| The following auxiliary characters are missing from the font: Ţ | |
| The following auxiliary characters are missing from the font: ţ | |
| Auxiliary orthography codepoints: | * lt_Latn (Lithuanian) |
| The following auxiliary characters are missing from the font: Ẽ | |
| The following auxiliary characters are missing from the font: Ĩ | |
| The following auxiliary characters are missing from the font: Ũ | |
| The following auxiliary characters are missing from the font: ẽ | |
| The following auxiliary characters are missing from the font: ĩ | |
| The following auxiliary characters are missing from the font: ũ | |
| Auxiliary orthography codepoints: | * en_Latn (English) |
| The following auxiliary characters are missing from the font: Ĕ | |
| The following auxiliary characters are missing from the font: Ĭ | |
| The following auxiliary characters are missing from the font: Ŏ | |
| The following auxiliary characters are missing from the font: Ō | |
| The following auxiliary characters are missing from the font: Ŭ | |
| The following auxiliary characters are missing from the font: ĕ | |
| The following auxiliary characters are missing from the font: ĭ | |
| The following auxiliary characters are missing from the font: ŏ | |
| The following auxiliary characters are missing from the font: ō | |
| The following auxiliary characters are missing from the font: ŭ | |
| The following auxiliary characters are missing from the font: ʻ | |
| Auxiliary orthography codepoints: | * nl_Latn (Dutch) |
| The following auxiliary characters are missing from the font: IJ | |
| The following auxiliary characters are missing from the font: ij | |
| Auxiliary orthography codepoints: | * ca_Latn (Catalan) |
| The following auxiliary characters are missing from the font: Ĕ | |
| The following auxiliary characters are missing from the font: Ĭ | |
| The following auxiliary characters are missing from the font: Ŀ | |
| The following auxiliary characters are missing from the font: Ŏ | |
| The following auxiliary characters are missing from the font: Ō | |
| The following auxiliary characters are missing from the font: Ŭ | |
| The following auxiliary characters are missing from the font: ĕ | |
| The following auxiliary characters are missing from the font: ĭ | |
| The following auxiliary characters are missing from the font: ŀ | |
| The following auxiliary characters are missing from the font: ŏ | |
| The following auxiliary characters are missing from the font: ō | |
| The following auxiliary characters are missing from the font: ŭ |
⚠️ WARN Font has correct separator glyphs? (googlefonts/separator_glyphs)
⚠️ WARN The following separator glyphs are missing:
- U+2028
- U+2029 [code: missing-separator-glyphs]
⚠️ WARN Ensure soft_dotted characters lose their dot when combined with marks that
replace the dot. (soft_dotted)
⚠️ WARN The dot of soft dotted characters used in orthographies must disappear in the following strings:
-
į̃
-
į̌
-
į̂
-
į̀
-
į́
-
į̄The dot of soft dotted characters should disappear in other cases, for example:
-
į̈
-
į̋
-
į̇
-
į̊
-
į̆ [code: soft-dotted]
ℹ️ INFO Checking OS/2 fsSelection value. (opentype/xavgcharwidth)
- ℹ️ INFO OS/2 xAvgCharWidth is 568 but it should be 567 which corresponds to the average of the widths of all glyphs in the font. These are similar values, which may be a symptom of the slightly different calculation of the xAvgCharWidth value in font editors. There's further discussion on this at com.google.fonts/test/034: xAvgCharWidth bakery vs glyphs vs font val fonttools/fontbakery#1622 [code: xAvgCharWidth-close]
ℹ️ INFO Familyname must be unique according to namecheck.fontdata.com (fontdata_namecheck)
- ℹ️ INFO The family name "Noto Sans Bengali" seems to be already in use.
Please visit http://namecheck.fontdata.com/ for more info. [code: name-collision]
ℹ️ INFO Show hinting filesize impact. (hinting_impact)
- ℹ️ INFO Hinting filesize impact:
| NotoSansBengali[wdth,wght].ttf | |
|---|---|
| Dehinted Size | 462836 |
| Hinted Size | 462860 |
| Increase | 24 |
| Change | 0.0 % |
ℹ️ INFO Font contains all required tables? (required_tables)
-
ℹ️ INFO This font contains the following optional tables:
loca
prep
GPOS
GSUB
gasp [code: optional-tables]
ℹ️ INFO Is the Grid-fitting and Scan-conversion Procedure ('gasp') table set to optimize rendering? (googlefonts/gasp)
- ℹ️ INFO These are the ppm ranges declared on the gasp table:
| PPM <= 65535 | - Use grid-fitting |
| | - Use grayscale rendering |
| | - Use gridfitting with ClearType symmetric smoothing |
| - Use smoothing along multiple axes with ClearType® | |
|---|---|
| [code: ranges] |
ℹ️ INFO Ensure fonts have ScriptLangTags declared on the 'meta' table. (googlefonts/meta/script_lang_tags)
-
ℹ️ INFO "as-Beng, bn-Beng" [code: dlng-tag]
-
ℹ️ INFO "as-Beng, bn-Beng, pi-Beng" [code: slng-tag]
ℹ️ INFO Font has old ttfautohint applied? (googlefonts/old_ttfautohint)
- ℹ️ INFO Could not detect which version of ttfautohint was used in this font. It is typically specified as a comment in the font version entries of the 'name' table. Such font version strings are currently: Version 3.010 [code: version-not-detected]
Summary
| 🔥 FAIL | ℹ️ INFO | ✅ PASS | ⏩ SKIP | |
|---|---|---|---|---|
| 4 | 10 | 11 | 150 | 35 |
| 2% | 5% | 5% | 72% | 17% |
Taken from the upstream repo https://github.com/notofonts/bengali at commit notofonts/bengali@07b2d57.
PR Checklist:
PR
QA
Specifics
primary_scriptdefinition in the METADATA.pb file for all projects that have a primary non-Latin based language support targetsubsetsdefinitions in the METADATA.pb reflect the actual subsets and languages present in the font files (in alphabetic order). For CJK fonts, only include one of the following subsetschinese-hongkong,chinese-simplified,chinese-traditional,korean,japanese.Release
minisite_urldefinition in the METADATA.pb file for commissioned projectstagsare added for NEW FONTS