Skip to content

Conversation

@simoncozens
Copy link
Collaborator

Taken from the upstream repo https://github.com/notofonts/bengali at commit notofonts/bengali@07b2d57.

PR Checklist:

PR

  • The PR is in the Traffic Jam Board (Project > Traffic Jam Board)
  • It has the correct labels (upgrade, new font, specific language)
  • The PR is linked to the corresponding issue

QA

  • Fontspector checks are reviewed and failing checks are resolved in collaboration with the upstream font development team
  • Diffenator2 and 3 regression checks for revisions on all projects that are currently in production
  • The article has no typos, images are properly linked and correctly sized
  • OFL.txt contains the correct license URL (https://openfontlicense.org)

Specifics

  • primary_script definition in the METADATA.pb file for all projects that have a primary non-Latin based language support target
  • subsets definitions in the METADATA.pb reflect the actual subsets and languages present in the font files (in alphabetic order). For CJK fonts, only include one of the following subsets chinese-hongkong, chinese-simplified, chinese-traditional, korean, japanese.

Release

  • Designers bio info have to be present in the designer catalog (at least an issue should be opened for tracking this, if they are not)
  • Check designers order in metadata.pb, since the first one of the list appears as “principal designer”
  • Social media content draft for all new commissioned projects in the Drive directory and Social Media tracker spreadsheet, communicate with the repository Maintainer so that they can push this content to the Social Media tracker spreadsheet
  • minisite_url definition in the METADATA.pb file for commissioned projects
  • tags are added for NEW FONTS

@github-actions
Copy link
Contributor

FontSpector report

fontspector version: 1.5.2

Check results

[1] ofl/notosansbengali/DESCRIPTION.en_us.html
🔥 FAIL Does DESCRIPTION file contain a upstream Git repo URL? (googlefonts/description/git_url)
  • 🔥 FAIL Please host your font project on a public Git repo (such as GitHub or GitLab) and place a link in the DESCRIPTION.en_us.html file. [code: lacks-git-url]
[2] ofl/notosansbengali/article/ARTICLE.en_us.html
🔥 FAIL Does DESCRIPTION file contain broken links? (googlefonts/description/broken_links)
  • 🔥 FAIL The following links are broken:
🔥 FAIL Does DESCRIPTION file contain a upstream Git repo URL? (googlefonts/description/git_url)
  • 🔥 FAIL Please host your font project on a public Git repo (such as GitHub or GitLab) and place a link in the DESCRIPTION.en_us.html file. [code: lacks-git-url]
[5] ofl/notosansbengali
🔥 FAIL Check samples can be rendered (googlefonts/metadata/can_render_samples)
  • 🔥 FAIL Font NotoSansBengali[wdth,wght].ttf cannot render Mundari sample text: সোবেন হোড়োকো কে মনরংগ ওড়োও অক্তিয়ার কো রেঅ͚ পইতিবাবত রে জনম জোরোংগ্এতে অহ্ডানড ওড়োও বরাবরী [code: sample-text]
⚠️ WARN Validate size, and resolution of article images, and ensure article page has minimum length and includes visual assets. (googlefonts/article/images)
  • ⚠️ WARN Article page lacks visual assets. [code: missing-visual-asset]
⚠️ WARN Check for codepoints not covered by METADATA subsets. (googlefonts/metadata/unreachable_subsetting)
  • ⚠️ WARN ofl/notosansbengali/NotoSansBengali[wdth,wght].ttf: The following codepoints supported by the font are not covered by any subsets defined in the font's metadata file, and will never be served. You can solve this by either manually adding additional subset declarations to METADATA.pb, or by editing the glyphset definitions.
  • U+02D8 BREVE: try adding one of: yi, canadian-aboriginal
  • U+02D9 DOT ABOVE: try adding one of: yi, canadian-aboriginal
  • U+02DB OGONEK: try adding one of: canadian-aboriginal, yi
  • U+0302 COMBINING CIRCUMFLEX ACCENT: try adding one of: math, cherokee, tifinagh, coptic
  • U+0306 COMBINING BREVE: try adding one of: tifinagh, old-permic
  • U+0307 COMBINING DOT ABOVE: try adding one of: hebrew, canadian-aboriginal, math, todhri, tifinagh, syriac, malayalam, duployan, coptic, tai-le, old-permic
  • U+030A COMBINING RING ABOVE: try adding one of: syriac, duployan
  • U+030B COMBINING DOUBLE ACUTE ACCENT: try adding one of: cherokee, osage
  • U+030C COMBINING CARON: try adding one of: cherokee, tai-le
    ... and 3 others

Or you can add the above codepoints to one of the subsets supported by the font: bengali, latin, latin-ext, menu [code: unreachable-subsetting]

ℹ️ INFO METADATA.pb subsets are correct? (googlefonts/metadata/subsets_correct)
  • ℹ️ INFO The subset 'latin-ext' is listed in production metadata, but only 0.10% of its glyphs are supported by this font file. We can't remove it, however, since that would cause a regression in production. [code: unsupported-production-subset]
ℹ️ INFO Check axis ordering on the STAT table. (googlefonts/STAT/axis_order)
  • ℹ️ INFO None of the fonts lack a STAT table.

    And these are the most common STAT axis orderings:
    wght-wdth: 1 [code: summary]

[1] ofl/notosansbengali/METADATA.pb
ℹ️ INFO Check METADATA.pb parses correctly (googlefonts/metadata/validate)
  • ℹ️ INFO Please consider adding a family.minisite_url entry. [code: lacks-minisite-url]
[15] ofl/notosansbengali/NotoSansBengali[wdth,wght].ttf
⚠️ WARN Check if each glyph has the recommended amount of contours. (contour_count)
  • ⚠️ WARN This check inspects the glyph outlines and detects the total number of contours in each of them. The expected values are
    inferred from the typical amounts of contours observed in a
    large collection of reference font families. The divergences
    listed below may simply indicate a significantly different
    design on some of your glyphs. On the other hand, some of these
    may flag actual bugs in the font such as glyphs mapped to an
    incorrect codepoint. Please consider reviewing the design and
    codepoint assignment of these to make sure they are correct.

    The following glyphs do not have the recommended number of contours:

  • uni0987 (U+0987): found 4, expected one of: {2, 1, 3}
  • uni0988 (U+0988): found 4, expected one of: {2, 1, 3}
  • uni0989 (U+0989): found 2, expected one of: {4, 1, 3}
  • uni098A (U+098A): found 2, expected one of: {3, 4, 1}
  • uni098B (U+098B): found 4, expected one of: {6, 2, 3}
  • uni0990 (U+0990): found 2, expected one of: {3, 1}
  • uni0995 (U+0995): found 3, expected one of: {5, 4, 2}
  • uni0998 (U+0998): found 1, expected one of: {5, 2}
  • uni099A (U+099A): found 1, expected one of: {2}
    ... and 9 others [code: contour-count]
⚠️ WARN Detect any interpolation issues in the font. (interpolation_issues)
  • ⚠️ WARN Glyph uni0983 has interpolation issues:
  • Contour order mismatch: [0, 1, 2, 3] in default vs [0, 3, 1, 2] in wght=900
  • Wrong start point: contour 2 should start at 7 in wght=900
  • Wrong start point: contour 3 should start at 2 in wght=900 [code: glyph]
⚠️ WARN Are there caret positions declared for every ligature? (ligature_carets)
  • ⚠️ WARN This font lacks caret position values for ligature glyphs on its GDEF table. [code: lacks-caret-pos]
⚠️ WARN Checking that the typoAscender exceeds the yMax of the /Agrave. (typoascender_exceeds_Agrave)
  • ⚠️ WARN OS/2.sTypoAscender value should be greater than 944, but got 917 instead [code: typoAscender]
⚠️ WARN Check font contains no unreachable glyphs (unreachable_glyphs)
  • ⚠️ WARN The following glyphs could not be reached by codepoint or substitution rules:
  • uni09A809CD.half [code: unreachable-glyphs]
⚠️ WARN Shapes languages in all GF glyphsets. (googlefonts/glyphsets/shape_languages)
  • ⚠️ WARN Warning language shaping:
Message Languages
Auxiliary orthography codepoints: * fi_Latn (Finnish)
The following auxiliary characters are missing from the font: Ǧ
The following auxiliary characters are missing from the font: Ǥ
The following auxiliary characters are missing from the font: Ȟ
The following auxiliary characters are missing from the font: Ǩ
The following auxiliary characters are missing from the font: Ŋ
The following auxiliary characters are missing from the font: Ŝ
The following auxiliary characters are missing from the font: Ţ
The following auxiliary characters are missing from the font: Ŧ
The following auxiliary characters are missing from the font: Ʒ
The following auxiliary characters are missing from the font: Ǯ
The following auxiliary characters are missing from the font: ǧ
The following auxiliary characters are missing from the font: ǥ
The following auxiliary characters are missing from the font: ȟ
The following auxiliary characters are missing from the font: ǩ
The following auxiliary characters are missing from the font: ŋ
The following auxiliary characters are missing from the font: ŝ
The following auxiliary characters are missing from the font: ţ
The following auxiliary characters are missing from the font: ŧ
The following auxiliary characters are missing from the font: ʒ
The following auxiliary characters are missing from the font: ǯ
Auxiliary orthography codepoints: * cs_Latn (Czech)
The following auxiliary characters are missing from the font: Ĕ * cy_Latn (Welsh)
The following auxiliary characters are missing from the font: Ĭ * es_Latn (Spanish)
The following auxiliary characters are missing from the font: Ŏ * hu_Latn (Hungarian)
The following auxiliary characters are missing from the font: Ō * pt_Latn (Portuguese)
The following auxiliary characters are missing from the font: Ŭ * sk_Latn (Slovak)
The following auxiliary characters are missing from the font: ĕ * tr_Latn (Turkish)
The following auxiliary characters are missing from the font: ĭ
The following auxiliary characters are missing from the font: ŏ
The following auxiliary characters are missing from the font: ō
The following auxiliary characters are missing from the font: ŭ
Auxiliary orthography codepoints: * da_Latn (Danish)
The following auxiliary characters are missing from the font: Ǿ
The following auxiliary characters are missing from the font: ǿ
Auxiliary orthography codepoints: * fr_Latn (French)
The following auxiliary characters are missing from the font: Ǔ
The following auxiliary characters are missing from the font: ſ
The following auxiliary characters are missing from the font: ǔ
Auxiliary orthography codepoints: * nb_Latn (Norwegian Bokmål)
The following auxiliary characters are missing from the font: Ǎ
The following auxiliary characters are missing from the font: Ŋ
The following auxiliary characters are missing from the font: Ŧ
The following auxiliary characters are missing from the font: ǎ
The following auxiliary characters are missing from the font: ŋ
The following auxiliary characters are missing from the font: ŧ
Auxiliary orthography codepoints: * de_Latn (German)
The following auxiliary characters are missing from the font: Ĕ
The following auxiliary characters are missing from the font: Ĭ
The following auxiliary characters are missing from the font: Ŏ
The following auxiliary characters are missing from the font: Ō
The following auxiliary characters are missing from the font: Ŭ
The following auxiliary characters are missing from the font: ĕ
The following auxiliary characters are missing from the font: ĭ
The following auxiliary characters are missing from the font: ŏ
The following auxiliary characters are missing from the font: ō
The following auxiliary characters are missing from the font: ſ
The following auxiliary characters are missing from the font: ŭ
Auxiliary orthography codepoints: * lv_Latn (Latvian)
The following auxiliary characters are missing from the font: Ō
The following auxiliary characters are missing from the font: Ŗ
The following auxiliary characters are missing from the font: ō
The following auxiliary characters are missing from the font: ŗ
Auxiliary orthography codepoints: * ro_Latn (Romanian)
The following auxiliary characters are missing from the font: Ţ
The following auxiliary characters are missing from the font: ţ
Auxiliary orthography codepoints: * lt_Latn (Lithuanian)
The following auxiliary characters are missing from the font: Ẽ
The following auxiliary characters are missing from the font: Ĩ
The following auxiliary characters are missing from the font: Ũ
The following auxiliary characters are missing from the font: ẽ
The following auxiliary characters are missing from the font: ĩ
The following auxiliary characters are missing from the font: ũ
Auxiliary orthography codepoints: * en_Latn (English)
The following auxiliary characters are missing from the font: Ĕ
The following auxiliary characters are missing from the font: Ĭ
The following auxiliary characters are missing from the font: Ŏ
The following auxiliary characters are missing from the font: Ō
The following auxiliary characters are missing from the font: Ŭ
The following auxiliary characters are missing from the font: ĕ
The following auxiliary characters are missing from the font: ĭ
The following auxiliary characters are missing from the font: ŏ
The following auxiliary characters are missing from the font: ō
The following auxiliary characters are missing from the font: ŭ
The following auxiliary characters are missing from the font: ʻ
Auxiliary orthography codepoints: * nl_Latn (Dutch)
The following auxiliary characters are missing from the font: IJ
The following auxiliary characters are missing from the font: ij
Auxiliary orthography codepoints: * ca_Latn (Catalan)
The following auxiliary characters are missing from the font: Ĕ
The following auxiliary characters are missing from the font: Ĭ
The following auxiliary characters are missing from the font: Ŀ
The following auxiliary characters are missing from the font: Ŏ
The following auxiliary characters are missing from the font: Ō
The following auxiliary characters are missing from the font: Ŭ
The following auxiliary characters are missing from the font: ĕ
The following auxiliary characters are missing from the font: ĭ
The following auxiliary characters are missing from the font: ŀ
The following auxiliary characters are missing from the font: ŏ
The following auxiliary characters are missing from the font: ō
The following auxiliary characters are missing from the font: ŭ
⚠️ WARN Font has correct separator glyphs? (googlefonts/separator_glyphs)
  • ⚠️ WARN The following separator glyphs are missing:
  • U+2028
  • U+2029 [code: missing-separator-glyphs]
⚠️ WARN Ensure soft_dotted characters lose their dot when combined with marks that replace the dot. (soft_dotted)
  • ⚠️ WARN The dot of soft dotted characters used in orthographies must disappear in the following strings:
  • į̃

  • į̌

  • į̂

  • į̀

  • į́

  • į̄The dot of soft dotted characters should disappear in other cases, for example:

  • į̈

  • į̋

  • į̇

  • į̊

  • į̆ [code: soft-dotted]

ℹ️ INFO Checking OS/2 fsSelection value. (opentype/xavgcharwidth)
ℹ️ INFO Familyname must be unique according to namecheck.fontdata.com (fontdata_namecheck)
  • ℹ️ INFO The family name "Noto Sans Bengali" seems to be already in use.
    Please visit http://namecheck.fontdata.com/ for more info. [code: name-collision]
ℹ️ INFO Show hinting filesize impact. (hinting_impact)
  • ℹ️ INFO Hinting filesize impact:
NotoSansBengali[wdth,wght].ttf
Dehinted Size 462836
Hinted Size 462860
Increase 24
Change 0.0 %
ℹ️ INFO Font contains all required tables? (required_tables)
  • ℹ️ INFO This font contains the following optional tables:

    loca
    prep
    GPOS
    GSUB
    gasp [code: optional-tables]

ℹ️ INFO Is the Grid-fitting and Scan-conversion Procedure ('gasp') table set to optimize rendering? (googlefonts/gasp)
  • ℹ️ INFO These are the ppm ranges declared on the gasp table:

| PPM <= 65535 | - Use grid-fitting |
| | - Use grayscale rendering |
| | - Use gridfitting with ClearType symmetric smoothing |

- Use smoothing along multiple axes with ClearType®
[code: ranges]
ℹ️ INFO Ensure fonts have ScriptLangTags declared on the 'meta' table. (googlefonts/meta/script_lang_tags)
  • ℹ️ INFO "as-Beng, bn-Beng" [code: dlng-tag]

  • ℹ️ INFO "as-Beng, bn-Beng, pi-Beng" [code: slng-tag]

ℹ️ INFO Font has old ttfautohint applied? (googlefonts/old_ttfautohint)
  • ℹ️ INFO Could not detect which version of ttfautohint was used in this font. It is typically specified as a comment in the font version entries of the 'name' table. Such font version strings are currently: Version 3.010 [code: version-not-detected]

Summary

🔥 FAIL ⚠️ WARN ℹ️ INFO ✅ PASS ⏩ SKIP
4 10 11 150 35
2% 5% 5% 72% 17%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant