Feat/short movie agents agent starter pack#1285
Open
maeve2024 wants to merge 4 commits intogoogle:mainfrom
Open
Feat/short movie agents agent starter pack#1285maeve2024 wants to merge 4 commits intogoogle:mainfrom
maeve2024 wants to merge 4 commits intogoogle:mainfrom
Conversation
zeroasterisk
previously approved these changes
Mar 18, 2026
zeroasterisk
previously approved these changes
Mar 18, 2026
Reverting: I was only supposed to approve the workflow runs, not the PR itself.
Signed-off-by: maeve2024 <156382087+maeve2024@users.noreply.github.com>
zeroasterisk
requested changes
Mar 19, 2026
| ) | ||
| return [ | ||
| image._gcs_uri.replace("gs://", AUTHORIZED_URI) | ||
| uri.replace("gs://", AUTHORIZED_URI) |
Collaborator
There was a problem hiding this comment.
where is this change from? what is the uri variable? this smells like hallucination which wouldn't work
| video.video.uri.replace("gs://", AUTHORIZED_URI) | ||
| for video in operation.result.generated_videos | ||
| for video in videos | ||
| if video.video and video.video.uri |
Collaborator
There was a problem hiding this comment.
what is going on here?
|
|
||
| You can use the [Agent Starter Pack](https://goo.gle/agent-starter-pack) to create a production-ready version of this agent with additional deployment options: | ||
|
|
||
| If you have [`uv`](https://github.com/astral-sh/uv) installed, you can create and set up your project with a single command: |
Collaborator
There was a problem hiding this comment.
Why not a copy/paste from the other PRs so they all share the same heading?
https://github.com/google/adk-samples/pull/1286/changes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Agent Starter Pack:
pyproject.toml
README.md
Build & lint:
pyproject.toml
uv.lock
Lint/type fixes:
app/story_agent.py
app/storyboard_agent.py
app/video_agent.py
app/utils/gcs.py and app/utils/tracing.py
Testing: