Skip to content

Feat/short movie agents agent starter pack#1285

Open
maeve2024 wants to merge 4 commits intogoogle:mainfrom
maeve2024:feat/short-movie-agents-agent-starter-pack
Open

Feat/short movie agents agent starter pack#1285
maeve2024 wants to merge 4 commits intogoogle:mainfrom
maeve2024:feat/short-movie-agents-agent-starter-pack

Conversation

@maeve2024
Copy link

Agent Starter Pack:

pyproject.toml

  • Added [tool.agent-starter-pack] with example_question and [tool.agent-starter-pack.settings] (agent_directory = "app").
  • Added agent-starter-pack>=0.14.1 to the dev dependency group.
  • app/agent.py
  • Added flexible auth block: set GOOGLE_CLOUD_PROJECT, GOOGLE_CLOUD_LOCATION, and GOOGLE_GENAI_USE_VERTEXAI from google.auth.default() so the agent works in ASP-generated projects.

README.md

  • Added a “Recommended: Using Agent Starter Pack” section before Requirements.
  • Primary flow: uvx agent-starter-pack create my-short-movie-agents -a adk@short-movie-agents.
  • Alternative pip/venv flow in a collapsible section.

Build & lint:

pyproject.toml

  • [project.optional-dependencies] with a lint extra (codespell, ruff, mypy) so make lint works.
  • [tool.codespell] with ignore-words-list = "rouge" to avoid false positives.

uv.lock

  • Regenerated with uv lock (includes agent-starter-pack and its dependencies).

Lint/type fixes:

app/story_agent.py

  • type: ignore[no-redef] on the fallback from adk.agents import Agent to satisfy mypy with the try/except import.

app/storyboard_agent.py

  • Only include images with a non-None _gcs_uri in the returned list so the result type is consistent.

app/video_agent.py

  • Guard on operation.result and use result.generated_videos or []; in the list comp, only include items where video.video and video.video.uri are set.

app/utils/gcs.py and app/utils/tracing.py

  • type: ignore[attr-defined] on from google.cloud import storage where mypy cannot resolve the storage attribute.

Testing:

  • Integration tests pass in an ASP-generated project; agent manually tested in ADK web UI (make playground).

zeroasterisk
zeroasterisk previously approved these changes Mar 18, 2026
zeroasterisk
zeroasterisk previously approved these changes Mar 18, 2026
@zeroasterisk zeroasterisk dismissed stale reviews from themself March 18, 2026 12:41

Reverting: I was only supposed to approve the workflow runs, not the PR itself.

maeve2024 and others added 2 commits March 18, 2026 11:54
)
return [
image._gcs_uri.replace("gs://", AUTHORIZED_URI)
uri.replace("gs://", AUTHORIZED_URI)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

where is this change from? what is the uri variable? this smells like hallucination which wouldn't work

video.video.uri.replace("gs://", AUTHORIZED_URI)
for video in operation.result.generated_videos
for video in videos
if video.video and video.video.uri
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what is going on here?


You can use the [Agent Starter Pack](https://goo.gle/agent-starter-pack) to create a production-ready version of this agent with additional deployment options:

If you have [`uv`](https://github.com/astral-sh/uv) installed, you can create and set up your project with a single command:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not a copy/paste from the other PRs so they all share the same heading?
https://github.com/google/adk-samples/pull/1286/changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants