Skip to content

feat(youtube-analyst): add Agent Starter Pack support#1284

Closed
maeve2024 wants to merge 7 commits intogoogle:mainfrom
maeve2024:feat/youtube-analyst-agent-starter-pack
Closed

feat(youtube-analyst): add Agent Starter Pack support#1284
maeve2024 wants to merge 7 commits intogoogle:mainfrom
maeve2024:feat/youtube-analyst-agent-starter-pack

Conversation

@maeve2024
Copy link

REVISION:

  • Added # noqa: E402 on the from .agent import root_agent line so ruff allows the non-top import.

CHANGES:

  • Add [tool.agent-starter-pack] and agent-starter-pack dev dep so the agent can be used as an ASP template.
  • Add flexible auth in init.py (google.auth.default + env setdefault) so it works with ADC, service accounts, and Cloud Run/GKE without hardcoding project/location.
  • Make ASP the main path in README and recommend uv one-liner first so users get a production-ready setup by default; clone-and-run is the fallback.
  • Remove load_artifacts from the root agent so ASP-generated projects pass integration tests when the Runner has no artifact service (avoids "Artifact service is not initialized").
  • Add pytest-asyncio and asyncio_mode = "auto" so generated projects’ async tests run without extra config.
    Regenerate uv.lock for new dev deps.

TESTS:
image
image

zeroasterisk
zeroasterisk previously approved these changes Mar 18, 2026
zeroasterisk
zeroasterisk previously approved these changes Mar 18, 2026
@zeroasterisk zeroasterisk dismissed stale reviews from themself March 18, 2026 12:41

Reverting: I was only supposed to approve the workflow runs, not the PR itself.


from google import genai
from google.adk.agents import Agent
from google.adk.tools import load_artifacts
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please explain why this is removed?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Answered in conversation

Remove load_artifacts from the root agent so ASP-generated projects pass integration tests when the Runner has no artifact service (avoids "Artifact service is not initialized").

Should we instead add an artifact service.

@tpryan do you have an opinion on this one?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To make sure I understand first:
youtube sample use the artifact service.
our test runner cannot run it because the artifact service is not enabled at the project level.
Can you point me to what would have to be done to enable that?

@maeve2024 maeve2024 closed this Mar 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants