Add support and compatibility with Bazel 8+#258
Open
cerisier wants to merge 3 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR was done as part of consuming rules_ml_toolchain from a Bazel 9 workspace.
It mostly consists of missing loads and
allow_emptystatements.The real important part is that protobuf was bumped to 33.0 (smallest version compatible with bazel 7, 8 and 9).
Futher versions break because Bazel 7 fails on newer ProtoInfo args.
If this is an issue downstream, I can drop that part and let users carry appropriate patches.
I forced materialized all repos with USE_BAZEL_VERSION 7 8 and 9 for validation.