Support regex pattern matching for metric thresholds#171
Merged
Conversation
|
Last Updated: 2026-05-12 21:20:22 UTC A/B Benchmark Results: Benchmark workflow e2e teste2e_bazel_benchmark_cpu_standard
Global Status: PASS Run History
|
pganssle-google
requested changes
May 11, 2026
pganssle-google
left a comment
pganssle-google
left a comment
There was a problem hiding this comment.
LGTM except for nits. Selecting "Request changes" because GH doesn't seem to have the concept of "Approved with comments"
pganssle-google
approved these changes
May 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds regex pattern matching for metric names to dynamically discover and track multiple TensorBoard tags from a single config. This eliminates massive boilerplate in large registries like TorchTPU.