Extract metric parser to shared lib and fix null bug#165
Merged
Conversation
|
Last Updated: 2026-05-12 21:59:09 UTC A/B Benchmark Results: Benchmark workflow e2e teste2e_bazel_benchmark_cpu_standard
Global Status: PASS Run History
|
Andrew-Dame
force-pushed
the
fix-artifact-only-wrklds
branch
from
c2006f1 to
92e9c20
Compare
pganssle-google
requested changes
May 11, 2026
pganssle-google
left a comment
pganssle-google
left a comment
There was a problem hiding this comment.
So only after writing all this did I realize that you are mostly just moving code around, so none of this is fully required, but I would still move the python_seed_env changes to a separate PR or at least its own commit (if you make them at all). If you make the other changes I requested, I would do them in a separate commit and make sure this gets merged as a merge commit or rebase and merge rather than squash merging.
pganssle-google
approved these changes
May 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR deduplicates the metric parsing logic by extracting it into a shared Bazel library, and applies the recent "artifact-only" null-handling fix to the static threshold analyzer.