Increase default kernel ridge value to ensure positive-definite kerne…#7
Open
MichelangeloConserva wants to merge 1 commit into
Open
Increase default kernel ridge value to ensure positive-definite kerne…#7MichelangeloConserva wants to merge 1 commit into
MichelangeloConserva wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was looking at the univariate regression problems implemented in the package, and I realized that the kernel_ridge default value is not sufficiently high to ensure that the kernel matrix is positive-definite. So all the univariate regression problems in the leaderboard (0-89) have nans in the target variables.
Increasing it a default value of 1e-5 solves the issue.