⚡ Optimize package listing handler to avoid blocking loop#49
Conversation
- Wrapped blocking `list_local_packages` in `spawn_blocking` - Added performance regression test (ignored by default) - Fixed clippy warning in server.rs Co-authored-by: mudcube <101564+mudcube@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
💡 What:
list_local_packagescall intokio::task::spawn_blockinginlist_packages_handlerinrust/vm-package-server/src/server.rs.rust/vm-package-server/tests/performance_test.rs(marked as#[ignore]) to verify blocking behavior.🎯 Why:
list_local_packagesperforms recursive directory walking usingstd::fs, which blocks the async executor thread./health) from being processed.📊 Measured Improvement:
Note: The
server.rsfile appeared to already have the optimization in the repository state, so this PR ensures it is present, fixes a lint issue, and adds the verification test.PR created automatically by Jules for task 4779412414185826968 started by @mudcube