⚡ Optimize and robustify version regex matching#44
Conversation
- Replace single `VERSION_REGEX` with `VERSION_REGEXES` using `OnceLock<Vec<Regex>>`. - Add fallback regex to support space-separated versions (e.g., `version 1.2.3`). - Prevent regex recompilation by using static initialization, solving the potential performance issue of recompiling fallbacks. - Iterate through regexes to find a match, improving robustness. Co-authored-by: mudcube <101564+mudcube@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
1 participant
Optimizes the regex matching in
version-syncby usingOnceLockfor a list of regexes. This allows supporting multiple version formats (like space-separated) without incurring the performance penalty of recompiling fallback regexes on every check. This addresses the issue whereunwrap_or_elsechains would cause inefficient recompilation, while also expanding the tool's compatibility with different version strings.PR created automatically by Jules for task 6328255529859741830 started by @mudcube