Skip to content

⚡ Optimize package listing handler with spawn_blocking #43

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mudcube merged 1 commit into from
Jan 28, 2026
Merged

⚡ Optimize package listing handler with spawn_blocking #43

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
46 changes: 32 additions & 14 deletions rust/vm-package-server/src/server.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -236,23 +236,41 @@ async fn health_handler() -> impl IntoResponse {

async fn list_packages_handler(State(state): State<Arc<AppState>>) -> impl IntoResponse {
// Pass data directory directly to avoid thread-unsafe directory changes
let result = crate::local_storage::list_local_packages(&state.data_dir);
let data_dir = state.data_dir.clone();
let result = tokio::task::spawn_blocking(move || {
crate::local_storage::list_local_packages(&data_dir)
})
.await;

match result {
Ok(packages) => {
let json = serde_json::to_string(&packages).unwrap_or_else(|_| "{}".to_string());
let mut headers = HeaderMap::new();
headers.insert(
header::CONTENT_TYPE,
"application/json"
.parse()
.expect("static header value is valid"),
);
(StatusCode::OK, headers, json)
}
Ok(inner_result) => match inner_result {
Ok(packages) => {
let json = serde_json::to_string(&packages).unwrap_or_else(|_| "{}".to_string());
let mut headers = HeaderMap::new();
headers.insert(
header::CONTENT_TYPE,
"application/json"
.parse()
.expect("static header value is valid"),
);
(StatusCode::OK, headers, json)
}
Err(e) => {
error!("Failed to list packages: {}", e);
let error_response = format!(r#"{{"error": "{e}"}}"#);
let mut headers = HeaderMap::new();
headers.insert(
header::CONTENT_TYPE,
"application/json"
.parse()
.expect("static header value is valid"),
);
(StatusCode::INTERNAL_SERVER_ERROR, headers, error_response)
}
},
Err(e) => {
error!("Failed to list packages: {}", e);
let error_response = format!(r#"{{"error": "{e}"}}"#);
error!("Task join error: {}", e);
let error_response = format!(r#"{{"error": "Internal Server Error"}}"#);
let mut headers = HeaderMap::new();
headers.insert(
header::CONTENT_TYPE,
Expand Down
Loading