Skip to content

⚡ Optimize Cargo Parser Regex Compilation #40

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mudcube merged 1 commit into from
Jan 28, 2026
Merged

⚡ Optimize Cargo Parser Regex Compilation #40

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions rust/vm-package-manager/src/links/cargo.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ use rayon::prelude::*;
use regex::Regex;
use std::collections::HashSet;
use std::process::Command;
use std::sync::OnceLock;
use vm_core::error::{Result, VmError};
use vm_core::vm_error;

Expand Down Expand Up @@ -46,8 +47,10 @@ fn parse_cargo_install_list(output: &str) -> Result<Vec<(String, String)>> {

// Regex to match cargo install list format:
// package_name v1.0.0 (/path/to/source):
let re = Regex::new(r"^([a-zA-Z0-9_-]+)\s+[^\(]*\(([^)]+)\):$")
.map_err(|e| VmError::Internal(format!("Failed to compile regex: {e}")))?;
static RE: OnceLock<Regex> = OnceLock::new();
let re = RE.get_or_init(|| {
Regex::new(r"^([a-zA-Z0-9_-]+)\s+[^\(]*\(([^)]+)\):$").expect("Failed to compile regex")
});

for line in output.lines() {
if let Some(captures) = re.captures(line) {
Expand Down
Loading