⚡ Bolt: Replace entry.path().is_file() with entry.file_type().is_some_and(|ft| ft.is_file())#599
Conversation
…nd(|ft| ft.is_file()) When using directory traversal crates like `ignore`, calling `entry.path().is_file()` performs an unnecessary `stat` syscall on the underlying path. By switching to `entry.file_type()`, the code can accurately use the file metadata already retrieved during the `readdir` operation, significantly speeding up directory traversals. Co-authored-by: mudcube <101564+mudcube@users.noreply.github.com>
Deploying typemill with
|
| Latest commit: |
8457372
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://8c60c239.typemill.pages.dev |
| Branch Preview URL: | https://bolt-optimize-directory-trav-93qi.typemill.pages.dev |
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 84573729c8
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| if entry.path().is_file() { | ||
| // Avoid `entry.path().is_file()` to prevent unnecessary `stat` syscalls, | ||
| // relying on the cached metadata from the `readdir` operation. | ||
| if entry.file_type().is_some_and(|ft| ft.is_file()) { |
There was a problem hiding this comment.
When the directory contains a symlink that resolves to a regular file, this replacement is not equivalent to the old check: Path::is_file() follows the link, but with the default WalkBuilder settings entry.file_type() reports the directory entry itself as a symlink, so the path is dropped from files_to_move. The directory rename still moves that symlink, so preview/result counts and detailed file lists under-report what was moved; the same filter pattern in the checksum/delete planners also stops checksumming these paths.
Useful? React with 👍 / 👎.
1 participant
💡 What: Replaced
entry.path().is_file()withentry.file_type().is_some_and(|ft| ft.is_file())across directory traversal operations inmill-servicesandmill-handlers.🎯 Why: Calling
entry.path().is_file()on anignore::DirEntryforces an unnecessarystat(orfs::metadata) syscall, bypassing the metadata already cached during the directory walking process.📊 Impact: Measurably improves directory traversal performance (scanning, pruning, renaming, checksum generation), especially for larger directories or slower file systems, by completely eliminating unnecessary syscalls.
🔬 Measurement: Observe faster execution times in
collect_files_in_dirand related file scanning operations in profiles/benchmarks.PR created automatically by Jules for task 16056078861206761684 started by @mudcube