Skip to content

πŸ›‘οΈ Sentinel: [CRITICAL] Fix SSRF vulnerability in web_fetch tool#590

Open
mudcube wants to merge 1 commit into
mainfrom
sentinel-ssrf-web-fetch-14048877648785991600
Open

πŸ›‘οΈ Sentinel: [CRITICAL] Fix SSRF vulnerability in web_fetch tool#590
mudcube wants to merge 1 commit into
mainfrom
sentinel-ssrf-web-fetch-14048877648785991600

Conversation

@mudcube

@mudcube mudcube commented Jun 8, 2026

Copy link
Copy Markdown
Contributor
  • 🚨 Severity: CRITICAL
  • πŸ’‘ Vulnerability: web_fetch allowed requesting arbitrary internal endpoints or localhost via direct or redirect-based SSRF.
  • 🎯 Impact: Attackers could read internal network resources or cloud metadata.
  • πŸ”§ Fix: Implemented manual DNS resolution, explicit filtering of private/local/unspecified IP ranges, manual redirect tracking (limit 5), and IP pinning using reqwest's resolve to prevent TOCTOU DNS rebinding.
  • βœ… Verification: Ran cargo test -p mill-plugin-system to ensure functionality.

PR created automatically by Jules for task 14048877648785991600 started by @mudcube

Co-authored-by: mudcube <101564+mudcube@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown
Contributor

πŸ‘‹ Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a πŸ‘€ emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@cloudflare-workers-and-pages

Copy link
Copy Markdown

Deploying typemill with Β Cloudflare Pages Β Cloudflare Pages

Latest commit: 5c45583
Status:Β βœ…Β  Deploy successful!
Preview URL: https://8be58dcb.typemill.pages.dev
Branch Preview URL: https://sentinel-ssrf-web-fetch-1404.typemill.pages.dev

View logs

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

πŸ’‘ Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 5c45583186

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with πŸ‘.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

if ipv4.is_multicast() {
return false;
}
true

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Block shared-address IPv4 ranges

The new SSRF gate still falls through to true for 100.64.0.0/10. When web_fetch is run on a host with services reachable on a CGNAT/overlay range, such as Tailscale addresses, or a metadata service exposed there, an attacker can supply a URL whose DNS result is in that range and the request will be pinned and sent, so the internal-resource read remains possible. This allowlist should reject shared-address/non-global IPv4 ranges before the final allow.

Useful? React with πŸ‘Β / πŸ‘Ž.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant