⚡ Bolt: [performance improvement]#586
Conversation
This replaces calls to `entry.path().is_file()` during `ignore::WalkBuilder` traversal with `entry.file_type().is_some_and(|ft| ft.is_file())` in several core components (`file_service/rename`, `checksums`, `directory_rename`, and `prune_ops`). The former executes an unnecessary `stat` syscall for every file, creating an I/O bottleneck on large directory walks. The latter leverages metadata pre-fetched natively by `readdir` avoiding the redundant lookup altogether. Co-authored-by: mudcube <101564+mudcube@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
Deploying typemill with
|
| Latest commit: |
ab69485
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://5eb4592d.typemill.pages.dev |
| Branch Preview URL: | https://bolt-optimize-directory-trav-b90z.typemill.pages.dev |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ab694859ca
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| for entry in walker.flatten() { | ||
| if entry.path().is_file() { | ||
| // Use file_type() to avoid unnecessary stat syscalls | ||
| if entry.file_type().is_some_and(|ft| ft.is_file()) { |
There was a problem hiding this comment.
When a directory contains a symlink to a regular file, this predicate now skips it because ignore::DirEntry::file_type() reports the entry itself as a symlink when WalkBuilder is using its default follow_links(false), whereas the previous entry.path().is_file() followed the link. Directory rename plans therefore omit those paths from file_checksums, so checksum validation no longer detects changes for symlinked files that are still moved as part of the directory operation; use metadata that follows links or explicitly handle symlinks if the previous behavior should be preserved.
Useful? React with 👍 / 👎.
1 participant
💡 What: Replaced occurrences of
entry.path().is_file()withentry.file_type().is_some_and(|ft| ft.is_file())across workspace directory traversals usingignore::WalkBuilder.🎯 Why:
entry.path().is_file()executes an unnecessarystatsyscall for each file, which can severely bottleneck performance during wide traversals.file_type()utilizes metadata already fetched byreaddir.📊 Impact: Significantly speeds up directory traversal routines (checksum calculations, renaming structures, and pruning workspaces), drastically reducing I/O operations and avoiding potentially tens of thousands of unnecessary syscalls on large repositories.
🔬 Measurement: Execute a codebase-wide rename or pruning operation on a very large repository and observe the reduction in time taken or use
straceto confirm the sharp reduction instat/lstatsyscalls.PR created automatically by Jules for task 8120242656058906040 started by @mudcube