⚡ Bolt: Replace entry.path().is_file() with entry.file_type() to eliminate stat syscall overhead#578
Conversation
…inate stat syscall overhead Co-authored-by: mudcube <101564+mudcube@users.noreply.github.com>
Deploying typemill with
|
| Latest commit: |
eee85e1
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://0b4f2d96.typemill.pages.dev |
| Branch Preview URL: | https://bolt-optimize-directory-trav-yxwo.typemill.pages.dev |
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: eee85e19a5
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| for entry in walker.flatten() { | ||
| if entry.path().is_file() { | ||
| // OPTIMIZATION: Use entry.file_type() from readdir instead of entry.path().is_file() to avoid stat syscalls | ||
| if entry.file_type().is_some_and(|ft| ft.is_file()) { |
There was a problem hiding this comment.
When the renamed directory contains a symlink that points to a regular file, this new predicate skips it because WalkBuilder is not configured with follow_links, so entry.file_type() reports the symlink itself rather than the target. The previous entry.path().is_file() followed the symlink and included that path in file_checksums; now those symlinked file entries are omitted from apply-time validation, so concurrent changes through those paths are no longer detected for directory renames. Consider falling back to entry.path().is_file() only for symlink entries if you want to avoid the extra stat for normal files.
Useful? React with 👍 / 👎.
1 participant
💡 What: Replaced
.path().is_file()with.file_type().is_some_and(|ft| ft.is_file())across directory traversal operations inmill-servicesandmill-handlers.🎯 Why: Calling
.is_file()on the.path()triggers a completely newstatfilesystem syscall for every entry when walking a directory. This is expensive on large directories. Usingentry.file_type()utilizes the metadata that was already retrieved natively during thereaddiroperation by the underlying traversal library (ignorecrate).📊 Impact: Significantly faster file discovery and directory walking, preventing unnecessary O(N) system calls across the workspace during operations like project indexing, renaming, pruning, and checksums.
🔬 Measurement: Verify tests run successfully via
cargo test -p mill-services -p mill-handlers. On larger codebases, system-level profiling via tools likestracewill show a dramatic reduction instatcalls during rename and prune operations.PR created automatically by Jules for task 17858767791468334036 started by @mudcube