⚡ Optimize repository discovery using filter_entry#19
Conversation
Refactored `find_repos_from_path` in `src/core/discovery.rs` to move repository detection logic inside the `WalkBuilder::filter_entry` closure.
Previously, the walker would yield every directory, and the visitor would perform a `path.join(".git").exists()` check, incurring a PathBuf allocation and a syscall for every visited directory.
The new implementation:
1. Enables `.hidden(false)` on the walker to allow it to see `.git` entries.
2. Detects `.git` entries directly in `filter_entry`.
3. When `.git` is found, it validates the repository and adds the parent path to the `DashMap`, then returns `false` to prevent descending into `.git`.
4. Manually filters other hidden files (e.g. `.config`, `.ssh`) to preserve the default behavior of ignoring hidden directories.
5. Retains the optimization of checking `contains_key` before allocation to handle duplicates efficiently (though duplicates are rare with this walker configuration).
This change eliminates O(N) allocations and syscalls (where N is the number of directories visited), significantly improving efficiency for deep directory trees and sparse repository structures.
Co-authored-by: mudcube <101564+mudcube@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
1 participant
Optimize repository discovery by leveraging
filter_entryto detect.gitdirectories directly, avoiding redundant syscalls and allocations for every visited directory.PR created automatically by Jules for task 5307878349262798214 started by @mudcube