Conversation
|
Are you still interested in this? There are conflicts that need to be resolved. |
Yes, i am, i will resolve conflicts soon. |
|
Finished with conflicts |
|
LGTM |
go.mod
Outdated
| @@ -1,4 +1,4 @@ | |||
| module github.com/golang/geo | |||
| module github.com/pavlov061356/geo | |||
There was a problem hiding this comment.
You're changing every file, which makes it hard to see where the real changes are.
Can you reduce this PR to just ChainInterpolationQuery? It will make it easier to review and we need think more before taking anything that gets the C++/Java/Go libraries out of sync. |
Already removed |
Hello, I have looked through your repository and, unfortunately, I haven't found a contribution guide. So, I welcome your suggestions.
Here, in this pull request, I have rewritten the S2ChainInterpolationQuery class as a golang struct with all the features and tests from the C++ library. Additionally, I have added a method for computing a "divided slice", just like the POSTGIS function ST_LineInterpolatePoints, but with the addition of chain edges to the resulting slice.