Misc CI bumps; replace cirrus freebsd with GHA; add all-done job#420
Misc CI bumps; replace cirrus freebsd with GHA; add all-done job#420kolyshkin wants to merge 5 commits into
Conversation
|
@guelfey PTAL 🙏 Among the other things, will allow to have a single "required" job for this repo (the "all-done" one). |
|
@guelfey PTAL |
This comment was marked as outdated.
This comment was marked as outdated.
| fail-fast: false | ||
| matrix: | ||
| go-version: ['1.20', '1.21', '1.22', '1.23'] | ||
| go-version: ['1.20', oldstable, stable] |
There was a problem hiding this comment.
This means we don't explicitly need to bump to 1.26 though as this is now stable? I like it - I see the risk of the build breaking when a new Go version is released very low (but if it indeed happens, I want to know early). And keeping 1.20 in there also lets us know if we for some reason accidentally increase the minimum version requirement.
There was a problem hiding this comment.
Yes, this means currently it's 1.25 and 1.26, and soon after the 1.27 release it will be changed to 1.26 and 1.27 with no input. I guess for a repo like this it makes sense.
The min version should be synced to one in go.mod. Actually I just went ahead and added a hack so that we don't have to specify the min version explicitly; please see the updated commit.
... to their latest versions. Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
Using @master is more prone to some breakage. Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
Use "oldstable" (currently 1.25) and "stable" (currently 1.26) aliases, so we always test the supported Go versions. Drop the 1.21, 1.22, and 1.23 from the matrix as they are no longer maintained / supported. Finally, add a hack to test against the Go version specified in go.mod, so we always test against a minimally supported version. For this to work, we had to checkout sources before installing Go. Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
This job depends on every other one, and thus makes it easier to set up "required" jobs in GHA CI (once this is merged, we only need "all-done" as required). Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
|
@guelfey I think I've addressed all the comments. Once (or just before) merging this, you need to modify repo branch protection rules to require "all-done" (and remove all the existing GHA checks). |
kolyshkin
force-pushed
the
bump-ci
branch
6 times, most recently
from
1d2eee1 to
0cfd164
Compare
kolyshkin
changed the title
Cirrus CI is being shut down. Let's use lima to bring up FreeBSD VM and test inside it. Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
|
OK, I've also replaced |
2 participants
Note: this currently includes #419 and #421 and is therefore a draft (will rebase once those are merged).This bumps various CI bits and pieces to their latest versions. See individual commits for details.
Also, since Cirrus CI is to be gone soon, let's replace it with GHA.
NOTE Once (or just before) merging this, you need to modify this repo branch protection rules: