Skip to content

CONNOBR-472 Validate French public IBANs#261

Closed
Sofjins wants to merge 3 commits intomasterfrom
CONNOBR-472-validate-fr-public-ibans
Closed

CONNOBR-472 Validate French public IBANs#261
Sofjins wants to merge 3 commits intomasterfrom
CONNOBR-472-validate-fr-public-ibans

Conversation

@Sofjins
Copy link
Copy Markdown

@Sofjins Sofjins commented Jul 21, 2025

CONNOBR-472

  • Added a list of FR public IBANs
  • Added a check to validate IBAN with according error message

@Sofjins Sofjins requested a review from Copilot July 22, 2025 05:24
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR implements validation for French public IBANs by adding a blacklist of publicly known IBANs that should be rejected during validation. The implementation includes a YAML data file containing 87 French public IBANs and integrates this check into the main IBAN validation flow.

  • Adds a new validation method not_a_public_iban? that checks French IBANs against a blacklist
  • Integrates the public IBAN check into the main valid_iban? validation method
  • Provides localized error messages in 13 languages for when a public IBAN is detected

Reviewed Changes

Copilot reviewed 14 out of 14 changed files in this pull request and generated 4 comments.

File Description
lib/ibandit/iban.rb Adds not_a_public_iban? method and integrates it into main validation
data/french_public_ibans.yml New YAML file containing list of 87 French public IBANs
spec/ibandit/iban_spec.rb Adds tests for the new validation and updates test fixture
config/locales/*.yml Adds error message translations in 13 languages

Copy link
Copy Markdown
Contributor

@JoeSouthan JoeSouthan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed, I'm not sure this is the right approach.

@Sofjins
Copy link
Copy Markdown
Author

Sofjins commented Jul 22, 2025

Closing, since it appeared the wrong place to insert these changes

@Sofjins Sofjins closed this Jul 22, 2025
@Sofjins Sofjins deleted the CONNOBR-472-validate-fr-public-ibans branch July 22, 2025 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants