Closed
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR implements validation for French public IBANs by adding a blacklist of publicly known IBANs that should be rejected during validation. The implementation includes a YAML data file containing 87 French public IBANs and integrates this check into the main IBAN validation flow.
- Adds a new validation method
not_a_public_iban?that checks French IBANs against a blacklist - Integrates the public IBAN check into the main
valid_iban?validation method - Provides localized error messages in 13 languages for when a public IBAN is detected
Reviewed Changes
Copilot reviewed 14 out of 14 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| lib/ibandit/iban.rb | Adds not_a_public_iban? method and integrates it into main validation |
| data/french_public_ibans.yml | New YAML file containing list of 87 French public IBANs |
| spec/ibandit/iban_spec.rb | Adds tests for the new validation and updates test fixture |
| config/locales/*.yml | Adds error message translations in 13 languages |
JoeSouthan
requested changes
Jul 22, 2025
Contributor
JoeSouthan
left a comment
There was a problem hiding this comment.
As discussed, I'm not sure this is the right approach.
Author
|
Closing, since it appeared the wrong place to insert these changes |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CONNOBR-472