There are cases where you want the delimiter to be a space#31
Open
arran4 wants to merge 1 commit intogobeam:masterfrom
Open
There are cases where you want the delimiter to be a space#31arran4 wants to merge 1 commit intogobeam:masterfrom
arran4 wants to merge 1 commit intogobeam:masterfrom
Conversation
I figure that if the user is just passing in a single " " then that would match that case. However it don't handle the case of multiple `" "` being intentional -- I'm not sure how you would want to handle this. Perhaps, if the change should be on 173?
13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I figure that if the user is just passing in a single " " then that would match that case. However it don't handle the case of multiple
" "being intentional -- I'm not sure how you would want to handle this.Perhaps, if the change should be on 173?
Description
When using this I found a case where I wanted a ' ' delimiter.
Fixes n/a
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
This has not been testing being trivial and expecting push back.
Checklist: