ValidateHook to validate the decoded value#103
Open
m1k1o wants to merge 1 commit intogo-viper:mainfrom
Open
Conversation
Member
|
Thanks for opening a PR! TBH, I'm a bit conflicted about this change. It feels out of scope for the library. I usually just write How much work would it be to externalize this feature to another library? Maybe I'm missing something? |
|
Tbh for validation I use zog. I have overall a system that uses https://github.com/knadh/koanf internally, which uses I kind of agree it is definitely possible to just validate an object after fully decoding it unless there is a very good reason not to? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Trying to merge changes in my fork of mapstructure, maybe you will be interested in such feature.
ValidateHook, if set, will be called after decoding is complete. This is useful for types that need a finalization step or validation. The ValidateHook is called for every map and value in the input. This means that if a struct has embedded fields with squash tags the post decode hook is called only once with all of the input data, not once for each embedded struct. If an error is returned, the entire decode will fail with that error.