Conversation
Add goleak.VerifyTestMain to catch goroutine leaks in tests.
|
Warning Rate limit exceeded
Your organization is not enrolled in usage-based pricing. Contact your admin to enable usage-based pricing to continue reviews beyond the rate limit, or try again in 8 minutes and 23 seconds. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Pull request overview
Adds goroutine leak detection to the tracing package test suite by wiring goleak.VerifyTestMain into TestMain.
Changes:
- Introduce
TestMainingoleak_test.goto rungoleak.VerifyTestMain(m)for the package’s tests. - Add
go.uber.org/goleak v1.3.0as a direct dependency ingo.mod.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| goleak_test.go | Adds package-level TestMain to enable goleak checks during go test. |
| go.mod | Declares goleak as a direct requirement to support the new test harness. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Summary
goleak.VerifyTestMainto catch goroutine leaks in testsTest plan
make testpasses with goleak enabledmake lintclean