Skip to content

feat: add goleak test coverage#26

Merged
ankurs merged 2 commits intomainfrom
feat/goleak
Apr 9, 2026
Merged

feat: add goleak test coverage#26
ankurs merged 2 commits intomainfrom
feat/goleak

Conversation

@ankurs
Copy link
Copy Markdown
Member

@ankurs ankurs commented Apr 9, 2026

Summary

  • Add goleak.VerifyTestMain to catch goroutine leaks in tests

Test plan

  • make test passes with goleak enabled
  • make lint clean

Add goleak.VerifyTestMain to catch goroutine leaks in tests.
Copilot AI review requested due to automatic review settings April 9, 2026 05:28
@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Apr 9, 2026

Warning

Rate limit exceeded

@ankurs has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 8 minutes and 23 seconds before requesting another review.

Your organization is not enrolled in usage-based pricing. Contact your admin to enable usage-based pricing to continue reviews beyond the rate limit, or try again in 8 minutes and 23 seconds.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 668be896-f3a5-42b3-b5c6-2f70a200cfd1

📥 Commits

Reviewing files that changed from the base of the PR and between dfc0e86 and 48f6d7e.

📒 Files selected for processing (2)
  • go.mod
  • goleak_test.go
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feat/goleak

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds goroutine leak detection to the tracing package test suite by wiring goleak.VerifyTestMain into TestMain.

Changes:

  • Introduce TestMain in goleak_test.go to run goleak.VerifyTestMain(m) for the package’s tests.
  • Add go.uber.org/goleak v1.3.0 as a direct dependency in go.mod.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
goleak_test.go Adds package-level TestMain to enable goleak checks during go test.
go.mod Declares goleak as a direct requirement to support the new test harness.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@ankurs ankurs merged commit f596f03 into main Apr 9, 2026
11 checks passed
@ankurs ankurs deleted the feat/goleak branch April 9, 2026 07:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants