feat(chart): add JWT audience, domain, prefix and extra claims settings#1
Merged
Merged
Conversation
- Add ENABLE_SWAGGER toggle under server settings - Expose JWT audience, domain and private claim prefix, omitting audience and domain when unset - Add STRICT_REDIRECT_URIS to the authorization code flow - Add caller-supplied extra claims limits for size, key count and value size - Document the new JWT and OAuth flow parameters in the README Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
There was a problem hiding this comment.
Pull request overview
Adds chart support for nine AuthGate environment variables (Swagger toggle, JWT audience/domain/private-claim prefix, strict redirect URIs, and four extra-claims limits) that previously had to be configured via extraEnv. Defaults match upstream so existing installs are unaffected.
Changes:
- Adds
server.enableSwagger,jwt.audience/domain/privateClaimPrefix,authCode.strictRedirectURIs, andextraClaims.*keys tovalues.yaml. - Renders the corresponding env vars in
templates/configmap.yaml, withif-guards for the optionalJWT_AUDIENCEandJWT_DOMAIN, and comma-joining audience list entries. - Documents the new parameters in
README.md(new JWT and OAuth Flow tables).
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| values.yaml | Adds new defaults and inline documentation for the nine new chart parameters. |
| templates/configmap.yaml | Renders new env vars into the ConfigMap, guarding optional ones and joining the audience list. |
| README.md | Adds JWT and OAuth Flow parameter tables documenting the new settings. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Widen the parameter column so the enableSwagger row lines up Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds 9 AuthGate environment variables that the chart was missing relative to upstream
internal/config/config.go/.env.example, so users can configure them throughvalues.yamlinstead of falling back toextraEnv: Swagger toggle, JWT audience/domain/private-claim-prefix, strict redirect URIs, and the 4 caller-supplied extra-claims limits. Defaults match upstream exactly, so a default install is unchanged.AI Authorship
values.yaml,templates/configmap.yaml,README.mdChange classification
helm install/pod startup, not system-wide.Plan reference
Goal: close the gap between the chart and AuthGate's supported env vars. New keys:
server.enableSwagger,jwt.audience(list → comma-joined),jwt.domain,jwt.privateClaimPrefix,authCode.strictRedirectURIs, and theextraClaims.*block (enabled,maxRawSize,maxKeys,maxValSize).Verification
helm lint+helm templateVerifiability check
Risk & rollback
JWT_AUDIENCE/JWT_DOMAINare{{- if }}-guarded so empty values omit the key (matching config.go "empty → omitted"). Defaults are unchanged for existing installs.extraEnv-based config still works.Reviewer guide
templates/configmap.yaml— confirm the audience list join, the conditional guards, and quoting match neighbours.values.yamldefaults (cross-check againstconfig.go) and theREADME.mdtables.🤖 Generated with Claude Code