Support chat blink and counter fix fedev-4067#2634
Open
timgmxio wants to merge 2 commits into
Open
Conversation
- useShowSupportChat: @privy-io/wagmi hardcodes reconnectOnMount: false,
so on page load wagmi reports plain "disconnected" (never
"reconnecting") while Privy restores the session — the
last-connected-state cache never engaged and was overwritten to false
on every load, hiding the Support button until the wallet reconnected.
Gate visibility and cache writes on wallet initialization
(privy/wallets ready + connecting/reconnecting) instead.
- useSupportChat: Intercom() from @intercom/messenger-js-sdk is a no-op
after the first call, so re-initialization after shutdown() (e.g. a
transient wagmi disconnect) left the messenger dead — no unread events
and the chat would not open until a full reload. Revive it with an
explicit boot() and reset the custom-attributes guard so they are
re-applied to the new session.
- useSupportChat: update({ theme_mode }) right after boot suppresses the
initial unread count delivery in the Intercom widget — this is why the
unread dot vanished on refresh until the messenger was opened manually
(verified against a minimal reproduction; attribute updates are
harmless). Pass theme_mode in the boot settings and send theme updates
only on actual theme switches.
Deduplicate the wallet-initialization check (Privy/wallets readiness + wagmi connecting status) previously inlined in EarnRedirect and useShowSupportChat.
Deploying gmx-interface-home with
|
| Latest commit: |
cfc1f71
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://19424e64.gmx-interface-home.pages.dev |
| Branch Preview URL: | https://support-chat-blink-and-count.gmx-interface-home.pages.dev |
Deploying gmx-interface with
|
| Latest commit: |
cfc1f71
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://12dba1b0.gmx-interface.pages.dev |
| Branch Preview URL: | https://support-chat-blink-and-count.gmx-interface.pages.dev |
timgmxio
changed the title
Playwright Component Test ReportAll tests passed. Commit cfc1f71 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.