Add PWA support FEDEV-3992#2622
Draft
qwinndev wants to merge 4 commits into
Draft
Conversation
Deploying gmx-interface-home with
|
| Latest commit: |
e208498
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://34333760.gmx-interface-home.pages.dev |
| Branch Preview URL: | https://pwa-support-fedev-3992.gmx-interface-home.pages.dev |
Deploying gmx-interface with
|
| Latest commit: |
e208498
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://f18e1954.gmx-interface.pages.dev |
| Branch Preview URL: | https://pwa-support-fedev-3992.gmx-interface.pages.dev |
qwinndev
changed the title
- Add VITE_APP_DISABLE_PWA kill-switch that unregisters the SW and clears its caches - Split shell/asset caches and cap the asset cache so it can't grow across deploys - Add behavior tests for public/sw.js and the kill-switch/error-swallow paths - Consolidate index.html theme-color to the dark brand #090A14 (drop duplicate) - Remove dead public/site.webmanifest - Shrink the app icon ~1.5x with transparent padding
- Pad the apple-touch-icon logo ~1.5x so it isn't full-bleed on iOS home screens - Use an opaque #090A14 background since iOS composites transparency to black
Playwright Component Test ReportAll tests passed. Commit e208498 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://linear.app/gmx-io/issue/FEDEV-3992/pwa-support
Changes
/favicon/manifest.json— name "App", broken icon paths, nostart_url/display) with a complete web app manifest at/manifest.json: GMX name, 192/512 icons,standalonedisplay, dark#090A14theme/background. Fixes the "app" install name on Android (FEDEV-2692; landing untouched)public/sw.jsservice worker: navigations network-first (new deploys picked up immediately); immutable/assets/served cache-first from a separate, size-capped asset cache; last successful shell kept as the offline fallbacksrc/lib/pwa/registerServiceWorker.ts); add aVITE_APP_DISABLE_PWA=truekill-switch that unregisters the worker and clears its caches (rollback path)index.html: consolidatetheme-colorto the dark brand#090A14(drop the conflicting duplicate); add standalone-mode meta tags for iOS home-screen installs#090A14tile (iOS composites transparency to black)public/site.webmanifestpublic/sw.js(install / activate cleanup / fetch caching branches) and the registration helper (prod gate, load timing, kill-switch, error swallow)