Warn when limit/stop increase may be liquidatable at trigger price FEDEV-2399#2581
Closed
qwinndev wants to merge 6 commits into
Closed
Warn when limit/stop increase may be liquidatable at trigger price FEDEV-2399#2581qwinndev wants to merge 6 commits into
qwinndev wants to merge 6 commits into
Conversation
…tor warning guard
Deploying gmx-interface with
|
| Latest commit: |
3fc41f8
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://ccd23dad.gmx-interface.pages.dev |
| Branch Preview URL: | https://fedev-2399.gmx-interface.pages.dev |
Playwright Component Test ReportAll tests passed. Commit 3fc41f8 |
Contributor
Author
|
Superseded by #2582 (branch renamed to fedev-2399-liquidatable-increase-warning for readability). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Warns users when a Limit Increase / Stop Increase order that increases an existing position would be liquidatable at its trigger (execution) price, so they can add collateral or reduce leverage before it triggers.
Linear: https://linear.app/gmx-io/issue/FEDEV-2399
Behavior
Changes
getIsPositionLiquidatableAtPriceshared helper (+ unit tests).!isLimit); newselectTradeboxIncreaseLiquidationRiskWarningselector.LiquidatableIncreaseWarningCard, reused in the tradebox and the order editor.Out of scope
LiquidatablePositionmessaging and the Market Increase block copy (already implemented).