feat(web): move project management into Settings; home becomes pure overview#254
Conversation
|
| Filename | Overview |
|---|---|
| apps/gmux-web/src/home.tsx | Projects section removed; home is now a pure activity overview with a contextual empty state pointing to Settings. Drag/reorder/remove machinery cleanly deleted. |
| apps/gmux-web/src/settings.tsx | New ConfiguredProjectsSection + ConfiguredProjectRow added at top of modal; drag/reorder/remove logic ported faithfully from home.tsx. File-header comment is now stale — still says reorder/removal live on the home dashboard. |
| apps/gmux-web/src/styles.css | Dead .home-project-* rules removed, replaced by .mp-configured-* equivalents with correct touch media query and hover-visible remove button. |
Flowchart
%%{init: {'theme': 'neutral'}}%%
flowchart TD
A[User opens Home] --> B{Has activity?}
B -- Yes --> C[Show Waiting / Active / Recent sections]
B -- No --> D{Has projects?}
D -- Yes --> E[Show: Nothing active right now]
D -- No --> F[Show: No projects yet — Add a project CTA]
F -->|onClick| G[Open Settings Modal]
H[User opens Settings Modal] --> I[ConfiguredProjectsSection\nYour projects: drag-to-reorder + remove]
I --> J[PeerReferencesSection\nFrom other hosts]
J --> K[DiscoveredSection\nDiscovered projects]
K --> L[Add local path section]
Prompt To Fix All With AI
Fix the following 2 code review issues. Work through them one at a time, proposing concise fixes.
---
### Issue 1 of 2
apps/gmux-web/src/settings.tsx:13-15
The file-header comment still says reorder/removal live on the home dashboard, but this PR is precisely the slice that moves them here. Future readers will get the opposite of the truth.
```suggestion
// A tab bar (Projects / Hosts) lands in a later slice. The
// configured-project manage-list (reorder + remove) is now at the
// top of the modal; the home dashboard is a pure activity overview.
```
### Issue 2 of 2
apps/gmux-web/src/home.tsx:27-28
`folders.value` is read a second time to derive `hasProjects`, even though the result was just stored in `foldersVal` on the line above. Using `foldersVal.length` avoids the redundant signal read.
```suggestion
const foldersVal = folders.value
const hasProjects = foldersVal.length > 0
```
Reviews (4): Last reviewed commit: "feat(web): move project management into ..." | Re-trigger Greptile
Try this PRcurl -sSfL https://gmux.app/install-pr.sh | sh -s -- 254Built from |
df03045 to
8783e9e
Compare
586887a to
78f6059
Compare
|
@greptile review |
8783e9e to
5a95681
Compare
Closes #250.
Summary
Second slice of the home/settings restructure (#250): move project management into Settings › Projects and make home a pure activity overview.
Changes
updateProjects) and remove (× →removeProject/removePeerReference). No navigation, no launch button. Sits at the top of the modal, above Discovered / Add-local-path.PeerLabelchip (status-aware, dims when the peer is offline); local rows get none. The host suffix and the "Remove reference" tooltip further distinguish them.ProjectRowcomponent and drag machinery move out ofhome.tsx.?settings; projects-exist-but-quiet → "Nothing active right now.".home-project-*/.home-add-projectCSS removed; ported to.mp-configured-*.Testing
?settingsopen preserves other query params (mock=1).