Open
Conversation
elementbound
reviewed
Jul 2, 2019
| { | ||
| var i, ds_map; | ||
| ds_map = argument0; | ||
| for (i = 0; script_exists(i); i += 1) { |
There was a problem hiding this comment.
Last time I've checked, the resource ID's are not necessarily contiguous. For example if you create three scripts, then delete the middle one, the id's will be [0, 2]. Has this changed since?
There was a problem hiding this comment.
Could be worth a check, maybe something like "haven't seen an existing script in the last 1024 iterations, let's just call it a day and return".
gmlscripts
force-pushed
the
master
branch
3 times, most recently
from
b7c4452 to
63a857c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
modification of map_backgrounds to work for scripts