Skip to content

feat(app): show SBP-2 device metadata #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
gly11 wants to merge 1 commit into
base: pr/bus-reset-capture-alignment
Choose a base branch
from
Draft

feat(app): show SBP-2 device metadata #9

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 37 additions & 0 deletions ASFW/Views/DeviceDiscoveryView.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -207,6 +207,11 @@ struct DeviceDetailView: View {
Text(String(format: "0x%06X", device.modelId))
.monospaced()
}
GridRow {
Text("Kind:")
.fontWeight(.medium)
Text(device.hasSBP2Unit ? "SBP-2 Device" : (device.isStorage ? "Storage" : "Other"))
}
}
.padding()
}
Expand Down Expand Up @@ -270,6 +275,38 @@ struct UnitCardView: View {
Text(String(format: "%d quadlets", unit.romOffset))
.monospaced()
}
if let managementAgentOffset = unit.managementAgentOffset {
GridRow {
Text("Mgmt Agent:")
.foregroundStyle(.secondary)
Text(String(format: "0x%08X", managementAgentOffset))
.monospaced()
}
}
if let lun = unit.lun {
GridRow {
Text("LUN:")
.foregroundStyle(.secondary)
Text(String(format: "0x%02X", lun))
.monospaced()
}
}
if let unitCharacteristics = unit.unitCharacteristics {
GridRow {
Text("Unit Chars:")
.foregroundStyle(.secondary)
Text(String(format: "0x%08X", unitCharacteristics))
.monospaced()
}
}
if let fastStart = unit.fastStart {
GridRow {
Text("Fast Start:")
.foregroundStyle(.secondary)
Text(String(format: "0x%08X", fastStart))
.monospaced()
}
}

if let vendorName = unit.vendorName, !vendorName.isEmpty {
GridRow {
Expand Down