Skip to content

fix(debug): handle unaligned bus reset captures #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
gly11 wants to merge 1 commit into
base: pr/swift-sbp2-connector
Choose a base branch
from
Draft

fix(debug): handle unaligned bus reset captures #8

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions ASFWDriver/Debug/BusResetPacketCapture.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,12 +51,17 @@ void BusResetPacketCapture::CapturePacket(const uint32_t* dmaQuadlets,
snapshot.captureTimestamp = GetCurrentTimestamp();
snapshot.generation = generation;

// Copy raw quadlets (little-endian from DMA)
std::memcpy(snapshot.rawQuadlets, dmaQuadlets, sizeof(snapshot.rawQuadlets));
// The synthetic bus-reset packet can be routed from an unaligned AR buffer.
// DriverKit's memcpy may still use wider loads, so copy byte-by-byte.
const auto* bytes = reinterpret_cast<const uint8_t*>(dmaQuadlets);
auto* rawBytes = reinterpret_cast<uint8_t*>(snapshot.rawQuadlets);
for (size_t i = 0; i < sizeof(snapshot.rawQuadlets); ++i) {
rawBytes[i] = bytes[i];
}

// Convert to wire format (big-endian)
for (int i = 0; i < 4; ++i) {
snapshot.wireQuadlets[i] = LEtoBE(dmaQuadlets[i]);
snapshot.wireQuadlets[i] = LEtoBE(snapshot.rawQuadlets[i]);
}

// Extract tCode from wire format Q0[31:28]
Expand Down