Conversation
- Add SortSlice function in pkg/lang/sort.go that performs stable in-place sorting - Add Compare function to support Clojure's compare semantics (nil handling, cross-type numeric comparison) - Update ToSlice to handle all required types: nil→empty, IPersistentVector, IPersistentMap, string→char array - Add transformation in rewrite.clj to replace java.util.Arrays.sort with SortSlice - Add transformation for clojure.lang.Util.compare to use Compare function The implementation matches Clojure JVM semantics: - Stable sort (equal elements maintain order) - Comparator contract (-1/0/1 return values) - Proper nil handling (nil sorts before non-nil) - Support for custom comparators
Signed-off-by: James Hamlin <jfhamlin@gmail.com>
Signed-off-by: James Hamlin <jfhamlin@gmail.com>
Signed-off-by: James Hamlin <jfhamlin@gmail.com>
Signed-off-by: James Hamlin <jfhamlin@gmail.com>
Signed-off-by: James Hamlin <jfhamlin@gmail.com>
Signed-off-by: James Hamlin <jfhamlin@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Comparerinterface for several Glojure core types, corresponding to JavaComparableThe implementation matches Clojure JVM semantics:
Also sneaking in a
formatmake command and some formatting fixes.Fixes #66
H/t to @ingydotnet for the nudge and some of the tests :)