docs(#279): draft canonical AGENTS.md for Codex review path#296
Closed
cbeaulieu-gt wants to merge 1 commit into
Closed
docs(#279): draft canonical AGENTS.md for Codex review path#296cbeaulieu-gt wants to merge 1 commit into
cbeaulieu-gt wants to merge 1 commit into
Conversation
Port the 696-line inline Claude pr-review prompt into Codex's P0/P1 review-guidance schema per Codex's AGENTS.md docs. Draft only -- gated on #295 validation of whether Codex Cloud env setup-scripts can deliver this file remotely. Content is the same either way; mechanism is what #Q decides. 19 rules across 7 thematic clusters (permissions, token/identity, shell discipline, action reference integrity, security, GitHub Actions conventions, container runtime). Mediums and Nits from the Claude prompt dropped -- Codex does not surface them. Refs #279, #294, #295. Co-Authored-By: Claude <noreply@anthropic.com>
Member
Author
Closing as supersededCodex evaluation has been pivoted to a scratch repo: The decision: the canonical This draft remains visible in git history as a reference for the rule-extraction work (7 themed clusters, 19 P0/P1 rules), but the file should not land on 🤖 Generated by Claude Code on behalf of @cbeaulieu-gt |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR drafts
AGENTS.mdat the repo root — the canonical Codex review-guidance file forglitchwerks/github-actionsand consumer repos that mirror its rules.It ports the existing 696-line inline Claude PR-review prompt into Codex's P0/P1 review-guidance schema. The result is 19 rules across 7 thematic clusters:
permissions:blocks;packages: readfor GHCR container jobsGITHUB_TOKENforclaude-code-action; PEM handlingshellcheck disable=SC2016on${{ }}in single-quoted strings; no standalonejq; uncapped polling loops./relative paths; SHA pinning for third-party actions; no expressions inuses:valuesgithub.event.*; secret echo; unguarded diff applicationconcurrency:on push+PR triggers; secret forwarding inworkflow_call/etc/gitconfigsafe.directorypreservation;ci-manifest.yamlref format; diff review disciplineWhat was dropped
Claude prompt material that did not port cleanly to P0/P1 vocabulary:
Why this is a draft
This PR is gated on issue #295 (the [Q] empirical validation sub-issue). Until #295 confirms whether Codex Cloud env setup-scripts can deliver
AGENTS.mdremotely or the repo must carry it as a committed file, the delivery mechanism is unresolved. The content is identical either way. Do not merge until #295 resolves.This PR contributes to the [A] sub-issue (#279) under the codex-pivot milestone but does not by itself satisfy its acceptance criteria — #295 resolution is required before the merge gate opens.
Refs #279, #294, #295.
🤖 Generated by Claude Code on behalf of @cbeaulieu-gt