Skip to content

Version 0.2.0#9

Merged
glennDittmann merged 3 commits intomainfrom
v-0.2.0
Apr 29, 2025
Merged

Version 0.2.0#9
glennDittmann merged 3 commits intomainfrom
v-0.2.0

Conversation

@glennDittmann
Copy link
Copy Markdown
Owner

Removes versioning from rita_test_utils, s.t. rita can be published to crates.io.

Also applies cargo fmt and cargo clippy.

Copilot AI review requested due to automatic review settings April 29, 2025 20:20
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes explicit versioning from the rita_test_utils dependency so that rita can be published to crates.io, and it applies formatting and lint-fixes from cargo fmt and cargo clippy.

  • Removed the version field from rita_test_utils in Cargo.toml
  • Rearranged and reformatted import orders and function signatures for improved consistency and readability
  • Updated macro formatting and loop structures without changing functionality

Reviewed Changes

Copilot reviewed 15 out of 15 changed files in this pull request and generated no comments.

Show a summary per file
File Description
rita_lab/src/types/file_handler.rs Reordered mpsc import order
rita_lab/src/panels/tabs/lab/central_panel.rs Adjusted import order and reformatted function definition
rita_lab/src/panels/tabs/debug/central_panel.rs Reformatted loop chaining in draw_triangles
rita/src/utils/convexity.rs Moved use declaration for geogram_predicates
rita/src/trids/tri_iterator.rs Updated module import order
rita/src/trids/tri_data_structure.rs Reformatted function parameter layout in flip_1_to_3
rita/src/trids/hedge_iterator.rs Updated import order for consistency
rita/src/tetds/tet_iterator.rs Adjusted import ordering
rita/src/tetds/tet_data_structure.rs Reordered imports and improved iterator logic formatting
rita/src/tetds/hedge_iterator.rs Reordered imports
rita/src/tetds/half_tri_iterator.rs Reordered imports
rita/src/lib.rs Removed an extra blank line
rita/Cargo.toml Removed versioning for rita_test_utils and reformatted nalgebra features
Comments suppressed due to low confidence (1)

rita/src/triangulation.rs:1111

  • Changing log_time to a const fn while calling non-const logging macros may lead to compile-time issues; consider reverting this change or refactoring the logging to work outside of a const context.
const fn log_time(&self) {

@glennDittmann glennDittmann merged commit 025b9fc into main Apr 29, 2025
3 checks passed
@glennDittmann glennDittmann deleted the v-0.2.0 branch April 29, 2025 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants