Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR removes explicit versioning from the rita_test_utils dependency so that rita can be published to crates.io, and it applies formatting and lint-fixes from cargo fmt and cargo clippy.
- Removed the version field from rita_test_utils in Cargo.toml
- Rearranged and reformatted import orders and function signatures for improved consistency and readability
- Updated macro formatting and loop structures without changing functionality
Reviewed Changes
Copilot reviewed 15 out of 15 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| rita_lab/src/types/file_handler.rs | Reordered mpsc import order |
| rita_lab/src/panels/tabs/lab/central_panel.rs | Adjusted import order and reformatted function definition |
| rita_lab/src/panels/tabs/debug/central_panel.rs | Reformatted loop chaining in draw_triangles |
| rita/src/utils/convexity.rs | Moved use declaration for geogram_predicates |
| rita/src/trids/tri_iterator.rs | Updated module import order |
| rita/src/trids/tri_data_structure.rs | Reformatted function parameter layout in flip_1_to_3 |
| rita/src/trids/hedge_iterator.rs | Updated import order for consistency |
| rita/src/tetds/tet_iterator.rs | Adjusted import ordering |
| rita/src/tetds/tet_data_structure.rs | Reordered imports and improved iterator logic formatting |
| rita/src/tetds/hedge_iterator.rs | Reordered imports |
| rita/src/tetds/half_tri_iterator.rs | Reordered imports |
| rita/src/lib.rs | Removed an extra blank line |
| rita/Cargo.toml | Removed versioning for rita_test_utils and reformatted nalgebra features |
Comments suppressed due to low confidence (1)
rita/src/triangulation.rs:1111
- Changing log_time to a const fn while calling non-const logging macros may lead to compile-time issues; consider reverting this change or refactoring the logging to work outside of a const context.
const fn log_time(&self) {
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes versioning from
rita_test_utils, s.t.ritacan be published tocrates.io.Also applies
cargo fmtandcargo clippy.