Add #![no_std] support#8
Merged
glennDittmann merged 9 commits intoglennDittmann:mainfrom Apr 25, 2025
Merged
Conversation
This also bumps a minor version as a public struct has changes to it's fields, one of which was public
|
@TimTheBig, looking good, thanks for putting in the effort and "no_std does not affect logic" is fantastic! |
Contributor
Author
|
@glennDittmann when can you review this? |
Owner
|
I can try tomorrow evening |
glennDittmann
previously approved these changes
Apr 24, 2025
Owner
glennDittmann
left a comment
glennDittmann
left a comment
There was a problem hiding this comment.
LGTM ! Great work, thanks a lot !
Just a tiny wording change please. :)
TimTheBig
commented
Apr 24, 2025
glennDittmann
requested changes
Apr 24, 2025
Owner
glennDittmann
left a comment
glennDittmann
left a comment
There was a problem hiding this comment.
this is the correct sentence :)
Co-authored-by: Glenn Dittmann <glenn.dittmann@posteo.de>
glennDittmann
approved these changes
Apr 25, 2025
|
Bravo!! |
Contributor
Author
|
Thank you |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch:
#![no_std]supportstd is still enabled be default, no_std does not affect logic.