fix: case-insensitive grep for CI readiness probe#28
Merged
Conversation
The readiness check greps for 'all hermes-agent services started and ready' but the log line capitalizes 'All' — grep -q is case-sensitive by default, causing the CI to timeout at 120s waiting for a match that never fires. Using -i flag makes the match case-insensitive.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The CI
build-testjob indocker-publish.ymlwaits for the container to report readiness before proceeding to port polling and self-check. The readiness probe greps the container logs for"all hermes-agent services started and ready"(lowercaseall), but the startup script emits"All hermes-agent services started and ready"(capital A).grep -qis case-sensitive by default, so the match never fires and the job times out after 120s — even though the container actually starts and passes all health checks.Commit Breakdown
fix: case-insensitive grep for CI readiness probe-iflag to the grep on line 82, making itgrep -qi"all"but the log line uses capital"All". Sincegrep -qis case-sensitive, the match never fires and the 120s timeout expires..github/workflows/docker-publish.yml(1 line changed)How to test locally
No local test needed — this is pure CI logic. The fix can be verified by:
build-testjob should now match on"All hermes-agent services started and ready"and proceed past the readiness wait.echo "All hermes-agent services started and ready." | grep -qi "all hermes-agent services started and ready"should exit 0.Checklist
Caveats
-iflag fully resolves the false-negative.