optimize dockerfile#2066
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 04dcd80299
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| && curl -fsSL "https://github.com/LukeMathWalker/cargo-chef/releases/download/v${CARGO_CHEF_VERSION}/cargo-chef-${chef_arch}.tar.gz" \ | ||
| | tar xz -C /usr/local/cargo/bin |
There was a problem hiding this comment.
Verify cargo-chef archive integrity before extracting
This change downloads and executes a release artifact directly from GitHub via curl | tar without validating its checksum or signature, which introduces a supply-chain regression compared to cargo install (which verifies crate checksums). In any CI or local build using this Dockerfile, a replaced/malicious asset at the same release URL would be unpacked and run as cargo-chef during the build, potentially compromising produced images.
Useful? React with 👍 / 👎.
No description provided.